`no_std` support for the `url` crate #831

domenukk · 2023-04-08T15:32:34Z

This extends/rebases/fixes #717.
All checks seem to pass.
For no_std support, however, as mentioned in #717, this still needs a bunch of fixes. Specifically, It looks like we'll have to use the ip_in_core nightly feature, or use this crate: https://docs.rs/no-std-net. I'd personally opt for nightly, as it looks like it will be merged eventually, but I could do both.

/edit: For future reference, in the meantime, net and the Error trait have made their way into core

Add default feature flag "std" that enables a `std::error::Error` impl for `Errors`.

domenukk · 2023-04-08T16:09:12Z

Went for ip_in_core now, so it needs nightly, but seems to work.

url/src/lib.rs

domenukk · 2023-04-10T13:54:26Z

I spent some time trying to get serde no_std support working, but it doesn't play nicely with the ip_in_core nightly feature - it throws errors like

the trait `Serialize` is not implemented for `Ipv6Addr`

valenting · 2023-04-10T13:59:54Z

Went for ip_in_core now, so it needs nightly, but seems to work.

If it breaks stable, that's obviously a no-go.
Also, our msrv is 1.56.0, so preferably the no_std changes would also work on that version.

codecov · 2023-04-10T13:59:55Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@6050a6e). Learn more about missing BASE report.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #831   +/-   ##
=======================================
  Coverage        ?   81.85%           
=======================================
  Files           ?       21           
  Lines           ?     3560           
  Branches        ?        0           
=======================================
  Hits            ?     2914           
  Misses          ?      646           
  Partials        ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

domenukk · 2023-04-10T14:15:12Z

It should not break stable, it should only "break" no_std (which never worked in the first place).
Switching to no-std-net also doesn't fix the problem with serde - the project seems stale/would need this to be merged:
dunmatt/no-std-net#16

domenukk · 2023-04-10T14:32:05Z

Moving to no-std-net anyway, since it seems to fit your msrv better

domenukk · 2023-04-16T23:43:04Z

Since I do need the nightly version, but I can see why some people wouldn't, I added two features:

no_std_net uses the no_std_net crate, no nightly needed (but the extra dependency)
unstable enabled unstable net_in_core feature, and also the error_in_core feature. Due to its opt-in nature, I would assume this is an okay solution (?)

Else we can wait until the features get stabilised.
Feedback welcome.

domenukk · 2023-04-16T23:45:21Z

idna/src/uts46.rs

@@ -453,7 +453,7 @@ impl Idna {
            return Errors::default();
        }
        let mut errors = processing(domain, self.config, &mut self.normalized, out);
-        self.output = std::mem::replace(out, String::with_capacity(out.len()));
+        self.output = core::mem::replace(out, String::with_capacity(out.len()));


FYI, this fixes a bug in the current idna no_std support. Why is it not caught in CI, and should I open an extra PR for it?

I recently dabbled with no_std stuff as well and I think the sure-fire way to test no_std compatibility is to:

target a platform that does not have std (certain ARM platforms) OR

have a really simple no_std binary crate which uses the libraries

Yes I'm trying it with cargo +nightly build -Zbuild-std=core,alloc --target aarch64-unknown-none -v --release --no-default-features

Could you split this off into a separate PR?

…ml on older rust versions)

domenukk · 2023-05-31T13:01:33Z

Any news on this? :)

domenukk · 2024-09-18T21:35:34Z

Error has since landed in core.
Apart from the potentially breaking feature flag, this PR is ready from my point of view.

Manishearth · 2024-09-18T21:53:26Z

url/src/lib.rs

+extern crate alloc;
+
+#[cfg(not(feature = "alloc"))]
+compile_error!("the `alloc` feature must be enabled");


issue: we should just not have an alloc feature, and unconditionally use alloc::Foo and core::Foo.

Happy to change it, however I assumed a subset of features may be possible without alloc - and then introducing those will be another breaking change. Adding a feature flag to Crates.toml isn't a lot of work for users

Also, all other crates like idna and data-url already have the alloc feature

If we wish to preplan for that I am happy to do so if someone can sketch out a viable plan for it, otherwise it feels like a premature optimization.

Furthermore as I said before adding new default features is typically not considered breaking in the ecosystem, and I do not consider it breaking here.

domenukk · 2024-09-18T21:56:55Z

A very similar discussion is going on over at thiserror: dtolnay/thiserror#304

Manishearth · 2024-09-19T16:01:04Z

CI is broken

I want to merge this only if @valenting also approves of the approach here.

madsmtm · 2024-09-19T18:56:54Z

I downloaded all the 186 possibly affected crates as determined by #831 (comment) (i.e. reverse-dependencies of url with default-features = false), and searched for instances of Url::socket_addrs, Url::from_file_path, Url::from_directory_path and Url::to_file_path.

Results:

vmemcached uses Url::socket_addrs in here.
wash-lib uses Url::from_file_path in here.
git-url-parse uses Url::from_file_path in here.
wick-sql uses Url::to_file_path in here.
wick-config uses Url::to_file_path in here.
release_plz_core uses Url::to_file_path in here.
wrpc-wasmtime-nats-cli uses Url::to_file_path in here.

I won't comment on whether that's an acceptable amount of breakage or not (I don't maintain this crate, so I don't really know what the general expected breakage is from any change), but it would be fairly actionable to go and submit PRs to fix these (I'm not motivated enough to do it myself) (git-url-parse and release_plz_core seems like the ones that the ecosystem would benefit the most from not breaking).

Manishearth · 2024-09-19T19:05:55Z

Oh, thank you so much for doing that work! That does give me some pause but yeah if we know which crates are doing it it's easy to patch out.

domenukk · 2024-09-20T10:38:04Z

I'm happy to open PRs to a handful of repositories, but since right now we don't have the std feature in url, we can't really do anything

madsmtm · 2024-09-20T12:59:24Z

I'm happy to open PRs to a handful of repositories, but since right now we don't have the std feature in url, we can't really do anything

They just have to remove default-features = false.

In order to make the rust-url compatible with no_std, the crate needs to introduce a `std` feature and make it default. See servo/rust-url#831. In order to reduce impact, downstream libraries should leave url's default features enabled (no other features are currently `default`).

In order to make the rust-url compatible with no_std, the crate needs to introduce a `std` feature and make it default. See servo/rust-url#831. To reduce impact, downstream libraries should leave url's default features enabled (no other features are currently `default`).

domenukk · 2024-09-20T13:23:19Z

Opened the PRs mentioned in #831 (comment)

In order to make the rust-url compatible with no_std, the crate needs to introduce a `std` feature and make it default. See servo/rust-url#831. In order to reduce impact, downstream libraries should leave url's default features enabled (no other features are currently `default`). Signed-off-by: Dominik Maier <dmnk@google.com>

In order to make the rust-url compatible with no_std, the crate needs to introduce a `std` feature and make it default. See servo/rust-url#831. In order to reduce impact, downstream libraries should leave url's default features enabled (no other features are currently `default`).

domenukk · 2024-09-20T19:33:15Z

git-url-parse and release_plz_core seems like the ones that the ecosystem would benefit the most from not breaking

The PRs in both crates have since been merged :)

madsmtm and others added 8 commits February 17, 2022 13:58

Make form_urlencoded no_std compatible

35653b0

Make data-url no_std compatible

194122c

Make idna no_std compatible

422a260

Add default feature flag "std" that enables a `std::error::Error` impl for `Errors`.

Test no_std support

81ee074

Initial work at making url no_std compatible

67d2a4c

Merge branch 'master' into no_std

db92dd2

Fixed testcases for no_std

bb7955a

fix no_std for nightly

a98aef8

domenukk marked this pull request as ready for review April 8, 2023 16:09

Add no_std to CI

0d14d5a

domenukk commented Apr 8, 2023

View reviewed changes

url/src/lib.rs Outdated Show resolved Hide resolved

Fix no_std for deps

315eb43

Moved to no-std-net

6d622ab

domenukk force-pushed the no_std branch from a2093b6 to 6d622ab Compare April 10, 2023 14:41

Added unstable, no_std_net options

3efe254

domenukk commented Apr 16, 2023

View reviewed changes

OverOrion mentioned this pull request Apr 18, 2023

Add support for no_std integritee-network/rust-url#1

Merged

domenukk added 4 commits April 27, 2023 15:28

Make CI happy by removing no-std-net/serde (not supported in Cargo.to…

36bc5b3

…ml on older rust versions)

Merge branch 'master' into no_std

29bfcf7

Only test aarch64 on ubuntu

e16eb2b

Fix CI some more

3dd87d8

OverOrion mentioned this pull request May 12, 2023

No std upstream working rust-nostr/nostr#90

Closed

3 tasks

Merge branch 'main' into no_std

3bf9eac

Manishearth reviewed Sep 18, 2024

View reviewed changes

domenukk added 2 commits September 19, 2024 16:31

Remove alloc feature flag

a73e755

Remove outdated comment

a4422a9

Manishearth approved these changes Sep 19, 2024

View reviewed changes

domenukk added 2 commits September 19, 2024 23:28

CI?

93c4871

Merge branch 'main' into no_std

c79a0d6

domenukk mentioned this pull request Sep 20, 2024

Enable default features for url crate vinted/vmemcached-rs#24

Open

domenukk mentioned this pull request Sep 20, 2024

fix: Enable default features for url crate wasmCloud/wasmCloud#3074

Closed

domenukk mentioned this pull request Sep 20, 2024

Enable default features for the url crate tjtelan/git-url-parse-rs#54

Merged

domenukk mentioned this pull request Sep 20, 2024

Enable default features for url crate candlecorp/wick#467

Open

domenukk mentioned this pull request Sep 20, 2024

Enable default features for url crate MarcoIeni/release-plz#1702

Merged

domenukk mentioned this pull request Sep 20, 2024

Enable default features for url crate bytecodealliance/wrpc#331

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`no_std` support for the `url` crate #831

`no_std` support for the `url` crate #831

domenukk commented Apr 8, 2023 •

edited

Loading

domenukk commented Apr 8, 2023

domenukk commented Apr 10, 2023

valenting commented Apr 10, 2023

codecov bot commented Apr 10, 2023 •

edited

Loading

domenukk commented Apr 10, 2023

domenukk commented Apr 10, 2023

domenukk commented Apr 16, 2023

domenukk Apr 16, 2023

OverOrion Apr 18, 2023

domenukk Apr 27, 2023

valenting Jun 14, 2023

domenukk commented May 31, 2023

domenukk commented Sep 18, 2024

Manishearth Sep 18, 2024

domenukk Sep 19, 2024 •

edited

Loading

domenukk Sep 19, 2024

Manishearth Sep 19, 2024

domenukk commented Sep 18, 2024

Manishearth commented Sep 19, 2024

madsmtm commented Sep 19, 2024 •

edited

Loading

Manishearth commented Sep 19, 2024

domenukk commented Sep 20, 2024

madsmtm commented Sep 20, 2024

domenukk commented Sep 20, 2024

domenukk commented Sep 20, 2024 •

edited

Loading

no_std support for the url crate #831

Are you sure you want to change the base?

no_std support for the url crate #831

Conversation

domenukk commented Apr 8, 2023 • edited Loading

domenukk commented Apr 8, 2023

domenukk commented Apr 10, 2023

valenting commented Apr 10, 2023

codecov bot commented Apr 10, 2023 • edited Loading

Codecov Report

domenukk commented Apr 10, 2023

domenukk commented Apr 10, 2023

domenukk commented Apr 16, 2023

domenukk Apr 16, 2023

Choose a reason for hiding this comment

OverOrion Apr 18, 2023

Choose a reason for hiding this comment

domenukk Apr 27, 2023

Choose a reason for hiding this comment

valenting Jun 14, 2023

Choose a reason for hiding this comment

domenukk commented May 31, 2023

domenukk commented Sep 18, 2024

Manishearth Sep 18, 2024

Choose a reason for hiding this comment

domenukk Sep 19, 2024 • edited Loading

Choose a reason for hiding this comment

domenukk Sep 19, 2024

Choose a reason for hiding this comment

Manishearth Sep 19, 2024

Choose a reason for hiding this comment

domenukk commented Sep 18, 2024

Manishearth commented Sep 19, 2024

madsmtm commented Sep 19, 2024 • edited Loading

Manishearth commented Sep 19, 2024

domenukk commented Sep 20, 2024

madsmtm commented Sep 20, 2024

domenukk commented Sep 20, 2024

domenukk commented Sep 20, 2024 • edited Loading

`no_std` support for the `url` crate #831

`no_std` support for the `url` crate #831

domenukk commented Apr 8, 2023 •

edited

Loading

codecov bot commented Apr 10, 2023 •

edited

Loading

domenukk Sep 19, 2024 •

edited

Loading

madsmtm commented Sep 19, 2024 •

edited

Loading

domenukk commented Sep 20, 2024 •

edited

Loading