Update unicode-width requirement from =0.1.12 to =0.1.13 #948
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Updates the requirements on [unicode-width](https://github.com/unicode-rs/unicode-width) to permit the latest version. - [Commits](unicode-rs/unicode-width@v0.1.12...v0.1.13) --- updated-dependencies: - dependency-name: unicode-width dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
|
Heads up unicode-width 0.1.13 changed how certain character widths are calculated to be more inline with the unicode spec. E.g. control characters like newline that were previously 0 width are now width 1. It doesn't appear that unicode-width is called directly by any code in this repo, but perhaps it's called by something downstream where this causes a meaningful change. @Manishearth I don't intend this to re-litigate the issue raised in unicode-rs/unicode-width#55 or unicode-rs/unicode-width#66. I'm merely raising a concern that this update may require additional testing beyond the usual amount that would seem obvious from a patch release. I am unaware of any particular problems this causes, and suspect there's a high chance that it would be none. |
|
No, the version is just pinned here because unicode-width (depended upon transitively by tests) has an MSRV greater than the MSRV tested in this CI (as we can see with the failing CI task). This is a dev dependency. The worst that can happen is tests will break, and we would notice that in CI. So no, this update would not require additional testing, @joshka even if you don't intend to relitigate the issue it sure feels like you're doing so by bringing it up on a place where it's very clearly not needed to be mentioned. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Updates the requirements on unicode-width to permit the latest version.
Commits
612877aBump to 0.1.13e370cb8Merge pull request #54 from krasimirgg/rustc3b82122adapt for rustc-dep-of-std buildd00d357Merge pull request #52 from Jules-Bertholet/canonically-equivalent-eawdc86c74Assign the same CJK width to canonically equivalent stringsa2db56bRefactorunicode.pyda626efMerge pull request #49 from Jules-Bertholet/syriac-abbreviation-mark47bac32Merge pull request #50 from Jules-Bertholet/remove-old-ci3742586Mark morePrepended_Concatenation_Marks as non-advancing3b56f6dMark U+A8FA DEVANAGARI CARET as zero-widthDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)