Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix debugger_visualizer test failures. #967

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Conversation

valenting
Copy link
Collaborator

The debugger_visualizer tests pass locally, but my cdb version is slightly newer.
Let's see if this works.

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@22b8237). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #967   +/-   ##
=======================================
  Coverage        ?   81.65%           
=======================================
  Files           ?       21           
  Lines           ?     3548           
  Branches        ?        0           
=======================================
  Hits            ?     2897           
  Misses          ?      651           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@valenting
Copy link
Collaborator Author

I installed the specific version locally, and it still passes.
I marked the test as continue-on-error instead.

@valenting valenting changed the title Make sure CDB is at the latest version Fix debugger_visualizer test failures. Sep 16, 2024
Copy link
Collaborator

@hsivonen hsivonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rs+

@valenting valenting added this pull request to the merge queue Sep 16, 2024
Merged via the queue into servo:main with commit 9404ff5 Sep 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants