-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Event.composedPath #31123
Implement Event.composedPath #31123
Conversation
🔨 Triggering try run (#7575738371) with platforms=linux and layout=all |
Test results for linux-wpt-layout-2013 from try job (#7575738371): Flaky unexpected result (13)
Stable unexpected results that are known to be intermittent (19)
Stable unexpected results (2)
|
Test results for linux-wpt-layout-2020 from try job (#7575738371): Flaky unexpected result (13)
Stable unexpected results that are known to be intermittent (16)
Stable unexpected results (2)
|
|
72f576a
to
2157266
Compare
@gterzian @mrobinson I test it on https://www.w3schools.com/jsreF/tryit.asp?filename=tryjsref_event_composedpath works and seems to give same result as Chrome and Firefox for event path, do you think this enough or I should do more? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks!
Couple of comments, and regarding the tests:
- I would expect this one to not error anymore:
expected: ERROR - There are some tests for this in the
shadow-dom
folder, which is currently skipped. It makes sense to unskip the folder by way of changes toinclude.ini
to see if any tests are passing.
tests/wpt/mozilla/meta/mozilla/service-workers/service-worker-registration.https.html.ini
Outdated
Show resolved
Hide resolved
Signed-off-by: Bentaimia Haddadi <haddadi.taym@gmail.com>
Signed-off-by: Bentaimia Haddadi <haddadi.taym@gmail.com>
2157266
to
f7a4429
Compare
Thanks @gterzian For 1 I am still getting:
for 2 maybe I am doing something wrong but I don't see |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I would say we leave the shadom-dom tests alone for now, because it looks like we are missing support for most of it so it is not worth it to unskip those tests. By the way they are skipped by default, so unskipping them means adding skip: false
to the .ini
file...
Signed-off-by: Bentaimia Haddadi <haddadi.taym@gmail.com>
🔨 Triggering try run (#7625578364) with platforms=linux and layout=all |
Test results for linux-wpt-layout-2020 from try job (#7625578364): Flaky unexpected result (16)
Stable unexpected results that are known to be intermittent (16)
|
Test results for linux-wpt-layout-2013 from try job (#7625578364): Flaky unexpected result (15)
Stable unexpected results that are known to be intermittent (15)
|
✨ Try run (#7625578364) succeeded. |
./mach build -d
does not report any errors./mach test-tidy
does not report any errors