Add width and height presentational hints for table-related elements
#33405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loirooriol
added
A-layout/table
A-layout/2020
|
🔨 Triggering try run (#10815737864) for Linux WPT |
|
We may need to handle zero especially in some cases:
Edit: addressed in #33425 |
|
Test results for linux-wpt-layout-2020 from try job (#10815737864): Flaky unexpected result (27)
Stable unexpected results that are known to be intermittent (15)
Stable unexpected results (10)
|
|
|
|
Oh, we are crashing the assert from #33098
|
Loirooriol
force-pushed
the
table-preshints
branch
from
3ccc607
to
faa1874
Compare
|
🔨 Triggering try run (#10831392427) for Linux WPT |
mrobinson
approved these changes
Sep 12, 2024
|
Test results for linux-wpt-layout-2020 from try job (#10831392427): Flaky unexpected result (17)
Stable unexpected results that are known to be intermittent (13)
|
|
✨ Try run (#10831392427) succeeded. |
We were only parsing the `width` attribute as a presentation hint for `<table>`, `<td>` and `<th>`. This patch also handles `<colgroup>` and `<col>`. Also, we weren't parsing `height` at all, now we do it for `<table>`, `<td>`, `<th>`, `<tr>`, `<tbody>`, `<thead>` and `<tfoot>`. One test is now crashing, but this was an existing issue: servo#33423 Signed-off-by: Oriol Brufau <obrufau@igalia.com> Co-authored-by: Martin Robinson <mrobinson@igalia.com>
Loirooriol
force-pushed
the
table-preshints
branch
from
faa1874
to
9b5d3f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were only parsing the
widthattribute as a presentation hint for<table>,<td>and<th>. This patch also handles<colgroup>and<col>.Also, we weren't parsing
heightat all, now we do it for<table>,<td>,<th>,<tr>,<tbody>,<thead>and<tfoot>.One test is now crashing, but this was an existing issue: #33423
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors