Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on 2015-01-28 nightly #59

Closed
wants to merge 2 commits into from

Conversation

aroben
Copy link
Contributor

@aroben aroben commented Jan 29, 2015

@aroben
Copy link
Contributor Author

aroben commented Jan 29, 2015

Looks like there are still warnings during cargo test.

src/lib.rs:28:1: 28:19 warning: use of unstable library feature 'test'
src/lib.rs:28 extern crate test;
              ^~~~~~~~~~~~~~~~~~
src/lib.rs:28:1: 28:19 help: add #![feature(test)] to the crate attributes to silence this warning
src/lib.rs:28 extern crate test;
              ^~~~~~~~~~~~~~~~~~
src/atom/mod.rs:472:13: 472:26 warning: use of unstable library feature 'std_misc': may change with specifics of new Send semantics
src/atom/mod.rs:472             Thread::spawn(move || {
                                ^~~~~~~~~~~~~
src/atom/mod.rs:472:13: 472:26 help: add #![feature(std_misc)] to the crate attributes to silence this warning
src/atom/mod.rs:472             Thread::spawn(move || {
                                ^~~~~~~~~~~~~

But I can't just add #![feature(test)] unconditionally, because then it will fail to build in non-test configurations. I'm not sure how to make an attribute conditional.

@aroben
Copy link
Contributor Author

aroben commented Jan 29, 2015

Figured it out.

@aroben aroben mentioned this pull request Jan 30, 2015
@kmcallister
Copy link
Contributor

Rolled this into #61.

@aroben aroben deleted the fix-nightly-c5961ad06-2015-01-28 branch January 30, 2015 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants