Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add target dependencies for apple m1 #225

Merged
merged 1 commit into from
Apr 23, 2021
Merged

add target dependencies for apple m1 #225

merged 1 commit into from
Apr 23, 2021

Conversation

zhengrenzhe
Copy link
Contributor

i build servo on my apple m1 macbook, but got error error[E0463]: can't find crate for 'objc' when compile surfman, so i add the target dependencies for apple m1.

i have already build passed and tested on my m1 macbook with command:

cargo build -p surfman
cargo test --lib

surfman/Cargo.toml Outdated Show resolved Hide resolved
@jdm
Copy link
Member

jdm commented Apr 23, 2021

@bors-servo r+
Thanks!

@bors-servo
Copy link
Contributor

📌 Commit 6670ffd has been approved by jdm

@bors-servo
Copy link
Contributor

⌛ Testing commit 6670ffd with merge 8dba5ea...

bors-servo added a commit that referenced this pull request Apr 23, 2021
add target dependencies for apple m1

i build servo on my apple m1 macbook, but got error `error[E0463]: can't find crate for 'objc' ` when compile surfman, so i add the target dependencies for apple m1.

i have already build passed and tested on my m1 macbook with command:

```
cargo build -p surfman
cargo test --lib
```
@bors-servo
Copy link
Contributor

💥 Test timed out

@jdm
Copy link
Member

jdm commented Apr 23, 2021

@bors-servo retry

@bors-servo
Copy link
Contributor

⌛ Testing commit 6670ffd with merge 3443ff7...

@bors-servo
Copy link
Contributor

☀️ Test successful - checks-travis
Approved by: jdm
Pushing 3443ff7 to master...

@bors-servo bors-servo merged commit 3443ff7 into servo:master Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants