Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use QuickCheck for test #13

Merged
merged 2 commits into from
Oct 12, 2020
Merged

Use QuickCheck for test #13

merged 2 commits into from
Oct 12, 2020

Conversation

CYBAI
Copy link
Member

@CYBAI CYBAI commented Oct 1, 2020

Current test cases are great enough though, I wonder if it's good to introduce quickcheck to have more randomness in the test cases.

Also, I added tests for front, find and touch in this PR.

(btw, I just noticed there's no CI for this repo 👀 maybe it's good to use GitHub Actions or Travis CI?)

@jdm
Copy link
Member

jdm commented Oct 1, 2020

Yes, adding CI to this repo would be nice.

@mbrubeck
Copy link
Collaborator

mbrubeck commented Oct 8, 2020

Thanks, this is very useful!

I'm not sure that every test needs to be a quickcheck test, though. For example, the new evict_all test doesn't really add any new coverage compared to the old one, since it only randomizes the stored values, which has no effect on the uluru code being tested.

For simplicity, could you keep the existing non-quickcheck tests, and use quickcheck only in new tests that benefit from the randomization?

@CYBAI
Copy link
Member Author

CYBAI commented Oct 9, 2020

Thanks, this is very useful!

I'm not sure that every test needs to be a quickcheck test, though. For example, the new evict_all test doesn't really add any new coverage compared to the old one, since it only randomizes the stored values, which has no effect on the uluru code being tested.

For simplicity, could you keep the existing non-quickcheck tests, and use quickcheck only in new tests that benefit from the randomization?

Indeed, that makes sense to me. I will update the PR to only use quickcheck for new tests! Thanks!

@mbrubeck mbrubeck merged commit d41097b into servo:master Oct 12, 2020
@CYBAI CYBAI deleted the quickcheck branch October 13, 2020 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants