Skip to content

Commit

Permalink
Changed plugin export for non-plugin-version (#153)
Browse files Browse the repository at this point in the history
* Changed plugin export for non-plugin-version

* Added export as default

Co-authored-by: Nestor Jodar <njodar@arsys.es>
  • Loading branch information
pngcsgta and njodar authored Jan 18, 2022
1 parent 67ca901 commit 3ab7214
Show file tree
Hide file tree
Showing 3 changed files with 56 additions and 95 deletions.
142 changes: 52 additions & 90 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/main.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import Vue from "vue";
import VueEllipseProgress from "@/plugin";
import vueEllipseProgress from "@/plugin";
import App from "./App.vue";

Vue.use(VueEllipseProgress);
Vue.use(vueEllipseProgress);

Vue.config.productionTip = false;

Expand Down
5 changes: 2 additions & 3 deletions src/plugin.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,5 @@ if (globalVue) {
globalVue.use({ install });
}

export default {
install,
};
export { VueEllipseProgress, install };
export default install;

2 comments on commit 3ab7214

@linuxnow
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guesss that this solvers the Could not find a declaration file for module 'vue-ellipse-progress' problem in Nuxt 3.

Can you please pull this patch in the @nuxt branch?

@setaman
Copy link
Owner

@setaman setaman commented on 3ab7214 Mar 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@linuxnow Version 2 provides both exports from the day one. The error you are facing sounds to me very TS related. TS is (currently) not officially supported. But you can take a look in the new unreleased docs for the usage in TS projects: https://setaman.github.io/vue-ellipse-progress-docs/guide/installation.html#typescript

Please sign in to comment.