Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implementation objects and more API functions #8

Merged
merged 9 commits into from
Nov 6, 2022
Merged

Conversation

sethaxen
Copy link
Owner

@sethaxen sethaxen commented Nov 6, 2022

This PR follows the example of posteriordb-python introducing an AbstractImplementation type with concrete types StanModelImplementation and PyMC3ModelImplementation. These types will make it easier to support implementations for more frameworks in the future.

It also renames load_values to load and introduces the function path.

@codecov
Copy link

codecov bot commented Nov 6, 2022

Codecov Report

Merging #8 (be0703f) into main (e12c4a7) will increase coverage by 0.74%.
The diff coverage is 96.15%.

@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
+ Coverage   79.61%   80.35%   +0.74%     
==========================================
  Files           7        8       +1     
  Lines         103      112       +9     
==========================================
+ Hits           82       90       +8     
- Misses         21       22       +1     
Impacted Files Coverage Δ
src/PosteriorDB.jl 100.00% <ø> (ø)
src/model.jl 41.17% <ø> (-8.83%) ⬇️
src/implementation.jl 92.30% <92.30%> (ø)
src/dataset.jl 50.00% <100.00%> (-3.34%) ⬇️
src/posterior_database.jl 95.00% <100.00%> (+0.26%) ⬆️
src/reference_posterior.jl 87.50% <100.00%> (-1.39%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sethaxen sethaxen merged commit 50ce0b2 into main Nov 6, 2022
@sethaxen sethaxen deleted the implementations branch November 6, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant