Add mset Callback interface #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sewenew
reviewed
Mar 6, 2024
| @@ -199,6 +199,13 @@ void AsyncTest<RedisInstance>::_test_hash() { | |||
| this->set_ready(); | |||
| }); | |||
| _wait(); | |||
|
|
|||
| set_ready(false); | |||
| std::map<std::string, std::string> mkeys = {{test_key("str")+"1", "val1"}, {test_key("str")+"2", "val2"}}; | |||
There was a problem hiding this comment.
- Use std::unordered_map instead of std::map, since this file doesn't include , some compiler might fail to compile.
- Register these two keys in KeyDeleter at the beginning of this method, so that they will be automatically deleted when the test is done.
auto key = test_key("set");
auto key1 = test_key("str1")
auto key2 = test_key("str2");
KeyDeleter<RedisInstance> deleter(_redis, {key, key1, key2});
// other code here
std::map<std::string, std::string> mkeys = {{key1, "val1"}, {key2, "val2"}}
|
Thanks for the contribution! I added a comment. Please fix it before I merge it. Thanks a lot! Regards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we need callback indicate mset request done.
test passed.