Update security-framework

[kornelski]

It's compatible, the major bump is for a dependency only.

[kornelski]

CircleCI won't let me see the failure without logging in, but I'm not going to log in, because last time I did it, it set up 157 GitHub hooks on my account.

[sfackler]

You don't need to log into Circle to see the failure.

error[E0277]: the trait bound `*const libc::c_void: core_foundation::base::ToVoid<*const std::os::raw::c_void>` is not satisfied
  --> /Users/distiller/.cargo/registry/src/github.com-1ecc6299db9ec823/security-framework-0.3.0/src/os/macos/certificate.rs:95:20
   |
95 |             self.0.find(oid.as_ptr() as *const c_void).map(|value| {
   |                    ^^^^ the trait `core_foundation::base::ToVoid<*const std::os::raw::c_void>` is not implemented for `*const libc::c_void`
   |
   = help: the following implementations were found:
             <*mut security_framework_sys::base::OpaqueSecCertificateRef as core_foundation::base::ToVoid<certificate::SecCertificate>>
             <*mut security_framework_sys::base::OpaqueSecIdentityRef as core_foundation::base::ToVoid<identity::SecIdentity>>
             <*mut security_framework_sys::base::OpaqueSecKeyRef as core_foundation::base::ToVoid<key::SecKey>>
             <*mut security_framework_sys::base::OpaqueSecAccessRef as core_foundation::base::ToVoid<os::macos::access::SecAccess>>
           and 30 others

[sfackler]

Ping

[kornelski]

I still can't see the CircleCI page. The details link looks like this to me (tried in private window):

[kornelski]

I've found that the build issue is caused by older Rust version. It builds with 1.30.0 and later.

Got it, it's due to c_void changing its identity. I'll have a fix soon.

[sfackler]

Oh weird. If you click on the specific failing build on the checks page you don't need to log in: https://circleci.com/gh/sfackler/rust-native-tls/204?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link

[kornelski]

Looks like the test has passed, https://circleci.com/gh/sfackler/rust-native-tls/207, but CicleCI didn't update GitHub status?

[sfackler]

The OSX build is still failing: https://circleci.com/gh/sfackler/rust-native-tls/206
Due to rust-lang/rustup#1794

[sfackler]

Thanks!