Fix race condition with X509Name creation

sfackler · Mar 24, 2023 · 6ced4f3 · 6ced4f3
1 parent a752805
commit 6ced4f3
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/openssl/src/x509/mod.rs b/openssl/src/x509/mod.rs
@@ -1045,7 +1045,10 @@ impl X509NameBuilder {
 
     /// Return an `X509Name`.
     pub fn build(self) -> X509Name {
-        self.0
+        // Round-trip through bytes because OpenSSL is not const correct and
+        // names in a "modified" state compute various things lazily. This can
+        // lead to data-races because OpenSSL doesn't have locks or anything.
+        X509Name::from_der(&self.0.to_der().unwrap()).unwrap()
     }
 }