-
-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add more x509 extension helper functions #1887
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfackler
reviewed
Apr 20, 2023
sfackler
reviewed
Apr 22, 2023
Can you add a test for these methods? |
I didn't found any certs with authority_issuer and authority_serial set, not even in the openssl tests. So should we keep them without tests? |
FWIW, you can almost always find X.509 test vectors for things by looking
in https://cryptography.io/en/latest/development/test-vectors/
…On Sun, Apr 23, 2023 at 8:03 AM Zhang Jingqiang ***@***.***> wrote:
I didn't found any certs with authority_issuer and authority_serial set,
not even in the openssl tests. So should we keep them without tests?
—
Reply to this email directly, view it on GitHub
<#1887 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAGBBAZG7HMTJ4FVMA5FLXCUZCFANCNFSM6AAAAAAXC2DHXU>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
All that is necessary for evil to succeed is for good people to do nothing.
|
yes, found one and updated |
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From https://www.openssl.org/docs/manmaster/man3/X509_get_extension_flags.html