rebuild openssl-sys if the underlying openssl has changed

[reaperhulk]

No description provided.

[sfackler]

I've considered doing something like this before, but I think it's a bit dangerous. With this specific setup, include_dir will be e.g. /usr/include on a system-wide install so you'd rebuild any time you updated any system header.

[reaperhulk]

I've updated the PR to use <include>/openssl

[alex]

`include_dir.join("openssl")`?

…

On Tue, Jan 30, 2024, 10:36 AM Steven Fackler ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In openssl-sys/build/main.rs <#2157 (comment)> : > @@ -79,6 +79,9 @@ fn main() { let target = env::var("TARGET").unwrap(); let (lib_dirs, include_dir) = find_openssl(&target); + if let Some(printable_include) = include_dir.to_str() { + println!("cargo:rerun-if-changed={}", printable_include); + } I've considered doing something like this before, but I think it's a bit dangerous. With this specific setup, include_dir will be e.g. /usr/include on a system-wide install so you'd rebuild any time you updated any system header. — Reply to this email directly, view it on GitHub <#2157 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAAGBHBB4P5TPA4D3ET2ETYREHQFAVCNFSM6AAAAABCRNKVNWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNJRGYZTMOJVGI> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[alex]

This can just be let ossl_include_dir = include_dir.join("openssl"); as far as I can tell

[alex]

(Not merging until @sfackler reviews)