Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Rsa::check_key doesn't leave errors on the stack #2279

Merged
merged 1 commit into from
Aug 17, 2024

Conversation

alex
Copy link
Collaborator

@alex alex commented Aug 17, 2024

No description provided.

@alex alex merged commit 7000b5d into sfackler:master Aug 17, 2024
61 checks passed
@alex alex deleted the rsa-check-key branch August 17, 2024 22:52
@sfackler
Copy link
Owner

@botovq
Copy link
Contributor

botovq commented Aug 25, 2024

As long as you don't ensure that the error stack is clean after every single test, I think you need to make sure you clean the stack before running a test that cares about it. Otherwise the assert isn't asserting what you want it to assert.

In this case, I'm pretty sure it's the md_ctx::test::verify_fail that left an error behind that the assert then picked up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants