chore(internet_port): added new ports and removed unnecessary string …

…class (apache#27078)
sfirke · Mar 22, 2024 · d33e71c · d33e71c
1 parent 38a3d24
commit d33e71c
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/superset/advanced_data_type/plugins/internet_port.py b/superset/advanced_data_type/plugins/internet_port.py
@@ -48,6 +48,11 @@
     "ldaps": [636],
     "imap2": [143],  # aka imap
     "imaps": [993],
+    "MySQL": [3306],
+    "Remote Desktop": [3389],
+    "dns": [53],
+    "ctf": [84],
+    "pdap": [344],
 }
 
 
@@ -83,9 +88,9 @@ def port_translation_func(req: AdvancedDataTypeRequest) -> AdvancedDataTypeRespo
                 else port_conversion_dict[string_value]
             )
         except (KeyError, ValueError):
-            resp["error_message"] = str(
-                f"'{string_value}' does not appear to be a port name or number"
-            )
+            resp[
+                "error_message"
+            ] = f"'{string_value}' does not appear to be a port name or number"
             break
         else:
             resp["display_value"] = ", ".join(