introduce new wfs 2.5D point source time domain driving function #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You have to merge #169 first in order to fix the CI error. |
fs446
force-pushed
the
wfs_td_point25d
branch
from
9c587c4 to
efdda38
Compare
|
Thanks for fixing things beforehand in #169! This PR is now updated by rebase. |
|
I re-opened this PR to improve and correct some docstring passages and to allow further double check / review. Thanks! |
|
I thik you have to create a bew pull request as you cannot merge here. |
fs446
pushed a commit
that referenced
this pull request
Jun 6, 2021
fs446
pushed a commit
that referenced
this pull request
Jun 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we introduced a new 2.5D WFS point source driving function in frequency domain with version 0.5.0 we should do this in time frequency as well for consistency, I'd propose.
Thus, for time domain same idea as for frequency domain: putting the new version into
point_25D()(this is the 3D->2.5D Delft approach) and creatingpoint_25d_legacy()that holds the function which was used up to <=0.6.0 (this is the 2D -> 2.5D approach by Rabenstein/Spors).Furthermore, some minor corrections in the math docstrings for the other time domain WFS functions and some pep8 issues fixed.
I would suggest to create a 0.6.1 minor release to introduce the new feature.