This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
Precompute fixed-length string dtypes #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomwhite
reviewed
Aug 7, 2020
| 1 1:7:A:C 0.0 7 C A | ||
| 1 1:8:A:C 0.0 8 C A | ||
| 1 1:9:A:C 0.0 9 C A | ||
| 1 1:1:G:CGCGCG 0.0 1 CGCGCG G |
There was a problem hiding this comment.
Can you document how you generated this file?
There was a problem hiding this comment.
Hm how about this:
- I'll add some notes for now saying this was created using software in a separate environment (hail)
- Create an issue to document this properly and include the associated code that created it
- Wait to see where the multi-repo conversation goes (https://github.com/pystatgen/sgkit/issues/65#issuecomment-670049733)
- Add this to the
validationfolder if we merge repos since it is essentially the same process as the one I used in the REGENIE and HWE PRs
That sound good? I'd rather not bootstrap another validation-like concept with all the associated CI changes if I can help it.
There was a problem hiding this comment.
@tomwhite does @eric-czech's proposal sound good?
There was a problem hiding this comment.
Yes (sorry forgot to reply) - sounds great!
There was a problem hiding this comment.
I'll add some notes for now saying this was created using software in a separate environment (hail)
|
@tomwhite can I get a sign off on those updates when you get a chance? |
tomwhite
approved these changes
Aug 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12
This also updates the test data to contain alleles and sample id strings that are longer to ensure that inferred data types are correct.
The function
_max_str_lenshould probably be a central utility, but we can address that in https://github.com/pystatgen/sgkit/issues/90.