-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop sorting config keys for newer ruby versions. #13
Conversation
* For ruby versions > 1.9.3 use order specified by user for configuration, otherwise sort it alphabetically. * Remove extraneous whitespace.
Sorry submitting on a different PR to #12 but I messed up my rebase. I've performed the changes asked for and added a bunch of tests because I didn't have any machines to test on with older ruby versions. I'll also look into fixing the lint issues picked up by rubocop. |
Other then the rubocop errors, it looks good to me. |
* For ruby versions > 1.9.3 use order specified by user for configuration, otherwise sort it alphabetically. * Remove extraneous whitespace.
Fixed most of them. What do we think about "Style/RegexpLiteral: Use %r around regular expression.". Usually I prefer using slashes as the regexp delimiter? |
I always go with the community recommendation. Unless you have a really good reason not to. |
Its much cleaner if you don't have to use the escapes. Escapes make it harder to read. |
* For ruby versions > 1.9.3 use order specified by user for configuration, otherwise sort it alphabetically. * Remove extraneous whitespace.
Force of habit really, which isn't a good enough reason. I have now fixed all rubocop issues and tests seem to all pass now. |
Super. Thanks for the contribution! |
Stop sorting config keys for newer ruby versions.
configuration, otherwise sort it alphabetically.