Add service_ensure option to allow control of services running or not #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Change looks good, except for $sssd_service which is removed from init.pp. Any reason for this? |
|
My bad, that what I was originally going to call the service_ensure parameter. Added it back in |
|
Ok then. Good contribution, thanks! :) |
sgnl05
added a commit
that referenced
this pull request
Oct 26, 2015
Add service_ensure option to allow control of services running or not
|
Is $sssd_ensure used? |
|
I see $sssd_ensure defined in init.pp, but I don't see it being used anywhere else. |
|
Good catch @edestecd It's not used anywhere. Probably an early variable name that was renamed to $ensure |
sgnl05
added a commit
that referenced
this pull request
Oct 27, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.