Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: add missing EOF and remove extra whitespaces and new lines #51

Merged
merged 7 commits into from
Jun 28, 2020

Conversation

saihaj
Copy link
Member

@saihaj saihaj commented Jun 26, 2020

Summary of PR

Removes trailing whitespaces and extra new lines.

Reviewers

@Harjot1Singh

code-factor and others added 2 commits June 25, 2020 22:04
 Apply fixes from CodeFactor
Codefactor suggestions
@saihaj saihaj requested a review from Harjot1Singh June 26, 2020 03:08
Copy link
Member

@Harjot1Singh Harjot1Singh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gosh, we really do need to figure out a CSS linter for the future, or move away from it to CSS-in-JS

src/components/RatioBox.css Outdated Show resolved Hide resolved
src/components/EditorPanel.css Outdated Show resolved Hide resolved
@saihaj
Copy link
Member Author

saihaj commented Jun 28, 2020

Compared to desktop this is less amount of work, we can probably start migrating this to CSS in JS. We can try prettier, but it gets annoying because of ESLint rules conflicts.

@saihaj saihaj changed the title refactor: remove extra spaces style: EOF, whitespaces and extra new lines Jun 28, 2020
@saihaj saihaj requested a review from Harjot1Singh June 28, 2020 15:31
@Harjot1Singh Harjot1Singh changed the title style: EOF, whitespaces and extra new lines style: add missing EOF and remove extra whitespaces and new lines Jun 28, 2020
@Harjot1Singh Harjot1Singh merged commit a3b111b into shabados:dev Jun 28, 2020
@saihaj saihaj deleted the refactor-cf-autofix branch June 28, 2020 15:33
@saihaj saihaj mentioned this pull request Jun 28, 2020
Harjot1Singh pushed a commit that referenced this pull request Jun 28, 2020
Co-authored-by: codefactor-io <support@codefactor.io>
Harjot1Singh added a commit that referenced this pull request Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants