Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bending machine wants to have the middle of the bend marked #33

Closed
easyw opened this issue May 7, 2018 · 7 comments
Closed

bending machine wants to have the middle of the bend marked #33

easyw opened this issue May 7, 2018 · 7 comments

Comments

@easyw
Copy link
Contributor

easyw commented May 7, 2018

Hi @shaise @ulrich1a
following this thread
https://forum.freecadweb.org/viewtopic.php?f=3&t=28331#p229621
it seems the SheetMetal WB should generate a sketch of middle of the bend.
It would be very useful to have also a similar option implemented.
Thanks for any insight.
Please find attached a simple FC file with the two sketches compared (one from the unfolded and one from the suggested middle references)
unfolding-FCStd.zip
unfolding-middle
shaise added a commit that referenced this issue Jun 25, 2018
@shaise
New feature: Generate unfold sketch with folding marks. Issue #33. Th…
f2b1104 
…ank you easyw-fc!

New feature: K-Factor foe unfolding is now editable. Issue #30
@shaise
Copy link
Owner

shaise commented Jun 25, 2018

sketch + bending marks added to ver 0.1.30

@shaise shaise closed this as completed Jun 25, 2018
@ceremcem ceremcem mentioned this issue Aug 18, 2018
Closed
@easyw
Copy link
Contributor Author

easyw commented Sep 17, 2018

Hi @shaise
I managed to obtain aSketch for the Outline of the unfolded part.
Please have a look at:
https://github.com/easyw/FreeCAD_SheetMetal/tree/test
(you need to check the option to have bending line sketch to trig this feature)
I haven't added the option to select a different color for the Outline but it can be easily added.
I tested the tool with some of the old critical file and it seems fine ...
Later, if this will be merged, it could be an easy way to remove the outline geometry from the 'Unfold_Sketch'
outwire-sketch

@easyw
Copy link
Contributor Author

easyw commented Sep 17, 2018

@shaise
I've added also a first attempt on Internal geometry sketch generation.
This is definitively to be improved. (like adding a small tolerance on geometry comparison).
Moreover also OutWire Sketch should have always the placement of the main Sketch.
(tested with this file 2ways.FCStd )
found here https://forum.freecadweb.org/viewtopic.php?f=10&t=11303&start=60#p171492

@shaise
Copy link
Owner

shaise commented Sep 17, 2018

the latest version already generates sketches with selectable colors. Did yo test it?

@easyw
Copy link
Contributor Author

easyw commented Sep 17, 2018

@shaise
yes, but I haven't added this option to the new sketches I'm creating ('Unfold_Sketch_OutWire', 'Unfold_Sketch_Internal').
Please have a try with my test branch and see what is generating.
here a test file within all the new sketches.
2ways-w_sketches.zip

@easyw
Copy link
Contributor Author

easyw commented Sep 18, 2018 •
edited
Loading

@shaise
now the routines are much cleaner and the sketches are in line with previous code.
Still I would need to generate the sketches aligned to the others in every face selection case...
Would you mind to have a look at the code?
Thx
Maurice
here a sample file
Cut-Unfolded-with-hole.zip

@easyw
Copy link
Contributor Author

easyw commented Sep 18, 2018

ok, I've managed to fix this...
I'm going to make a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@easyw @shaise