fix: Remove all variables and most functions from global scope #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid name collisions on sites due to common names, e.g. Uncaught SyntaxError: Identifier 'options' has already been declared This also updates to use version 1.0.2 of trace-anything. Changes have been formatted with Chromium's JavaScript formatter.
beback4u
approved these changes
Jan 10, 2023
There was a problem hiding this comment.
LGTM. Confirmed with @jrummell-chromium that the integration test works as expected along with the EME formatter in person.
joeyparrish
approved these changes
Jan 10, 2023
beback4u
pushed a commit
that referenced
this pull request
Mar 30, 2023
🤖 I have created a release *beep* *boop* --- ## [3.3.0](v3.2.0...v3.3.0) (2023-01-10) ### Features * EME Logger Manifest V3 Migration ([#51](#51)) ([c860eba](c860eba)) ### Bug Fixes * Display keystatuseschange.expiration as a Date ([#48](#48)) ([d5d15f6](d5d15f6)), closes [#42](#42) * Remove all variables and most functions from global scope ([#61](#61)) ([3b8ed85](3b8ed85)), closes [#44](#44) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid name collisions on sites due to common names, e.g. Uncaught SyntaxError: Identifier 'options' has already been declared
This also updates to use version 1.0.2 of trace-anything.
Changes have been formatted with Chromium's JavaScript formatter.
Fixes #44