-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Customize WebDriver config in custom launcher #35
Conversation
I think this is really useful. But for shaka-player, I think those settings you quote in the PR description should be the defaults for Firefox. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@@ -61,6 +62,10 @@ const LocalWebDriverBase = function(baseBrowserDecorator, logger) { | |||
|
|||
log.debug('config:', JSON.stringify(config)); | |||
|
|||
const extraSpecs = | |||
_.merge(this.constructor.EXTRA_WEBDRIVER_SPECS, args.config); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please document the config
field in the Configuration section of the README?
Also, could you please add this to the EXTRA_WEBDRIVER_SPECS for Firefox launchers by default?
'moz:firefoxOptions': {
prefs: {
'media.eme.enabled': true,
'media.gmp-manager.updateEnabled': true,
},
},
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. I hope provided example is good enough.
Update README
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
🤖 I have created a release *beep* *boop* --- ## [1.6.0](v1.5.0...v1.6.0) (2022-03-23) ### Features * Customize WebDriver config in custom launcher ([#35](#35)) ([c8fe569](c8fe569)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Example of custom launcher with this PR: