Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix missing lodash dependency #39

Merged
merged 1 commit into from
Apr 21, 2022

Conversation

joeyparrish
Copy link
Member

@joeyparrish joeyparrish commented Apr 20, 2022

A dependency on lodash was introduced in #35, but lodash was only a transitive dep for the launcher. Since #35 made the dependency on it a direct one, it should be explicit in package.json.

@joeyparrish joeyparrish requested a review from theodab April 20, 2022 22:53
@joeyparrish joeyparrish merged commit cc3f4c0 into shaka-project:main Apr 21, 2022
@joeyparrish joeyparrish deleted the fix-missing-deps branch April 21, 2022 00:19
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Aug 17, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants