Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Safari Technology Preview, iOS and iPadOS with simulators #33

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

tykus160
Copy link
Member

@tykus160 tykus160 commented Mar 10, 2022

Works OK with Technology Preview and simulators. Wasn't able to check on actual devices.

@google-cla
Copy link

google-cla bot commented Mar 10, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@joeyparrish
Copy link
Member

This is great, thanks! I'll try it out in our lab before merging, but it looks good to me.

@joeyparrish
Copy link
Member

I was able to test Safari TP, but on iOS it failed initially because it tried to connect to localhost. After modifying shaka-player's karma.conf.js to set the hostname field to the mac's IP, that worked. However, we then have shaka-player test failures on iOS related to MediaSource (which isn't available on the platform and is unconditionally referenced in the tests).

So there is some follow-on work necessary in Shaka Player, but this PR is definitely working. Thank you for this!

@joeyparrish joeyparrish merged commit 3af8414 into shaka-project:main Mar 10, 2022
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Aug 17, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants