Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AV1 codec string generated by Shaka packager stops after the bit depth field #1007

Closed
johnsim opened this issue Nov 18, 2021 · 0 comments · Fixed by #1312
Closed

AV1 codec string generated by Shaka packager stops after the bit depth field #1007

johnsim opened this issue Nov 18, 2021 · 0 comments · Fixed by #1312
Labels
status: archived Archived and locked; will not be updated

Comments

@johnsim
Copy link

johnsim commented Nov 18, 2021

System info

Operating System: all
Shaka Packager Version: master branch

Issue and steps to reproduce the problem

The AV1 codec string generated by Shaka packager stops after the bit depth field. This means it does not support monochrome signaling nor HDR.

av1_codec_configuration_record.cc#L87

The unit tests seem to suggest it's being tested for weird combinations of subsampling but the expected codecs string completely omits those parts.

Maybe there is a misunderstanding with the sentence:

All the other fields (including their leading '.') are optional, mutually inclusive (all or none) fields. If not specified then the values listed in the table below are assumed.

"optional" means: not needed when the values not printed are using the default value, but mandatory whenever they are different from the default.

For additional information, see
AV1 Codec ISO Media File Format Binding v1.2.0, Clause 5 Codecs Parameter String

Packager Command:

Extra steps to reproduce the problem?
(1)
(2)

What is the expected result?

What happens instead?

<Please attach the input files or email to shaka-packager-issues@google.com.>
@CaitlinOCallaghan CaitlinOCallaghan mentioned this issue May 3, 2023
Merged
This was referenced Jul 25, 2023
Draft
Closed
@cosmin cosmin closed this as completed in cc9a691 Aug 4, 2023
This was referenced Aug 29, 2023
Merged
Merged
joeyparrish pushed a commit that referenced this issue Aug 30, 2023
@CaitlinOCallaghan
feat: Write colr atom to muxed mp4 (#1261)
f264bef 
This PR is an extension of the full AV1 codec string feature: [PR
1205](#1205) and
relates to [Issue
1007](#1007) and
[Issue
1202](#1202).

As per the AV1 spec, the codec string may contain optional color values.
These color values are critical for detecting HDR video streams - see
[Issue
1007](#1007).
Color information is extracted from the input mp4's `colr` atom and used
to generate the full AV1 codec string. This PR preserves the color
information by writing the `colr` atom to the muxed mp4.

**References**:
- [AV1 Codec ISO Media File Format
Binding](https://aomediacodec.github.io/av1-isobmff/#codecsparam)
- [AV1 Bitstream & Decoding Process
Specification - Section 6.4.2 Color config semantics (page
117)](https://aomediacodec.github.io/av1-spec/av1-spec.pdf)
- [QuickTime File Format
Specification](https://developer.apple.com/library/archive/documentation/QuickTime/QTFF/QTFFChap3/qtff3.html#//apple_ref/doc/uid/TP40000939-CH205-125526)
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Oct 3, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(main): release 3.0.0 shaka-project/shaka-packager
1 participant
@johnsim