test: Disable codec switch smooth test if changeType() is unavailable (…

…#7410) Previously we were disabling tests only by using `supportsSmoothCodecSwitching()` method, but it checks only user agent and not API existence.
shaka-project · Oct 10, 2024 · 16753e7 · 16753e7
1 parent 51d00b8
commit 16753e7
Showing 1 changed file with 16 additions and 4 deletions.
diff --git a/test/codec_switching/codec_switching_integration.js b/test/codec_switching/codec_switching_integration.js
@@ -91,8 +91,11 @@ describe('Codec Switching', () => {
     });
 
     it('can switch codecs SMOOTH', async () => {
+      if (!shaka.media.Capabilities.isChangeTypeSupported()) {
+        pending('SourceBuffer.changeType is not supported');
+      }
       if (!shaka.util.Platform.supportsSmoothCodecSwitching()) {
-        pending('Mediasource.ChangeType is not considered ' +
+        pending('SourceBuffer.changeType is not considered ' +
           'reliable on this device');
       }
       if (!await Util.isTypeSupported('audio/webm; codecs="opus"')) {
@@ -160,8 +163,11 @@ describe('Codec Switching', () => {
     });
 
     it('can switch codecs SMOOTH', async () => {
+      if (!shaka.media.Capabilities.isChangeTypeSupported()) {
+        pending('SourceBuffer.changeType is not supported');
+      }
       if (!shaka.util.Platform.supportsSmoothCodecSwitching()) {
-        pending('Mediasource.ChangeType is not considered ' +
+        pending('SourceBuffer.changeType is not considered ' +
           'reliable on this device');
       }
       if (!await Util.isTypeSupported('audio/webm; codecs="opus"')) {
@@ -229,8 +235,11 @@ describe('Codec Switching', () => {
     });
 
     it('can switch codecs SMOOTH', async () => {
+      if (!shaka.media.Capabilities.isChangeTypeSupported()) {
+        pending('SourceBuffer.changeType is not supported');
+      }
       if (!shaka.util.Platform.supportsSmoothCodecSwitching()) {
-        pending('Mediasource.ChangeType is not considered ' +
+        pending('SourceBuffer.changeType is not considered ' +
           'reliable on this device');
       }
       if (!await Util.isTypeSupported('audio/mp4; codecs="ec-3"')) {
@@ -299,8 +308,11 @@ describe('Codec Switching', () => {
     });
 
     it('can switch codecs SMOOTH', async () => {
+      if (!shaka.media.Capabilities.isChangeTypeSupported()) {
+        pending('SourceBuffer.changeType is not supported');
+      }
       if (!shaka.util.Platform.supportsSmoothCodecSwitching()) {
-        pending('Mediasource.ChangeType is not considered ' +
+        pending('SourceBuffer.changeType is not considered ' +
           'reliable on this device');
       }
       if (!await Util.isTypeSupported('audio/mp4; codecs="ec-3"')) {