Skip to content

Commit

Permalink
test: Fix exceptions in tests (#4772)
Browse files Browse the repository at this point in the history
This fixes a test exception that did not fail its tests.  An HlsParser
instance outlived the test run and failed after server disconnection.

This issue was spotted while running the tests in a local browser in
debug mode. It caused no test failures directly, but was an example of
poor hygiene in our tests.
  • Loading branch information
joeyparrish committed Dec 8, 2022
1 parent dccb28d commit 640dcb7
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions test/hls/hls_parser_unit.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ describe('HlsParser', () => {

afterEach(() => {
shaka.log.alwaysWarn = originalAlwaysWarn;
parser.stop();
});

beforeEach(() => {
Expand Down

0 comments on commit 640dcb7

Please sign in to comment.