Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo: Add field for chapters URL when adding custom content #5932

Closed
absidue opened this issue Nov 27, 2023 · 2 comments · Fixed by #5934
Closed

Demo: Add field for chapters URL when adding custom content #5932

absidue opened this issue Nov 27, 2023 · 2 comments · Fixed by #5934
Labels
component: demo page The issue is in the demo page; does not affect production applications priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone

Comments

@absidue
Copy link

absidue commented Nov 27, 2023

Have you read the FAQ and checked for duplicate open issues?
Yes

Is your feature request related to a problem? Please describe.

When using the demo player to check if bugs are reproducible there instead of just the custom app, you can't currently add chapters unless they are in the manifest.

Describe the solution you'd like

It would be nice to have a text field for a chapters URL, next to the existing one for a thumbnails URL.

Describe alternatives you've considered

Asking shaka-player contributors to add the chapters through the browser's dev tools console.

Additional context

I wanted to report two UI bugs but noticed that the demo doesn't make it easy to add custom characters.

The first one is that when both chapters and thumbnails are used that the same time (currently no demo assets available with both), the chapter text is displayed below the thumbnail on the z-axis, so you can't see it.

The other is that because the chapter labels are limited to the width of the segment, long ones on short chapters get aggressively wrapped and overflow below the bottom of the player.

@absidue absidue added the type: enhancement New feature or request label Nov 27, 2023
@avelad avelad added component: UI The issue involves the Shaka Player UI priority: P3 Useful but not urgent component: demo page The issue is in the demo page; does not affect production applications and removed component: UI The issue involves the Shaka Player UI labels Nov 27, 2023
@avelad avelad added this to the v5.0 milestone Nov 27, 2023
@avelad
Copy link
Member

avelad commented Nov 27, 2023

In this issue we will talk about improving the Demo, please create specific issues for chapter issues. Thank you!

@avelad
Copy link
Member

avelad commented Nov 27, 2023

I have a working PR with this, so it will be available in v5.0 and in the nightly soon

@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jan 27, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jan 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: demo page The issue is in the demo page; does not affect production applications priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants