Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PreferredVideoLabel Configuration to allow setting a preference when codecs are the same #5947

Closed
koenoe opened this issue Nov 28, 2023 · 0 comments · Fixed by #5948
Closed
Labels
priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone

Comments

@koenoe
Copy link
Contributor

koenoe commented Nov 28, 2023

Have you read the FAQ and checked for duplicate open issues?
Yes

Is your feature request related to a problem? Please describe.
We currently have DASH manifests where we have both audio- and video tracks with the same codecs, but we'd still like to configure a preference. E.g. we have Dolby Atmos and Dolby Digital Plus audio tracks that use the ec-3 codec. In order to configure a preference we use preferredAudioLabel to choose one over the other (we've added labels to our manifest to facilitate this). We have a similar issue with video tracks, where we have HDR and SDR in hev1 codecs, but currently no way to configure a preference to choose one over the other. Especially during playback when ABR kicks in, it's not ideal for a user to constantly switch between HDR and SDR.

Describe the solution you'd like
I'd like a configuration like preferredAudioLabel where we can configure a preference apart from codec, I thought preferredVideoLabel would make sense.

Describe alternatives you've considered
We've played around with the setting preferredVideoHdrLevel but this only seems to help with PQ vs HLG, not for SDR.

Additional context
I'm not sure if this is the correct solution, but it makes sense to me. Happy to listen to alternative ideas or solutions. I'm eager to contribute as well, hence why I've already created a PR.

In order to start the discussion, or perhaps accept this change, I've submitted a PR (#5948) for this.

@koenoe koenoe added the type: enhancement New feature or request label Nov 28, 2023
@shaka-bot shaka-bot added this to the Backlog milestone Nov 28, 2023
@avelad avelad modified the milestones: Backlog, v5.0 Nov 29, 2023
@avelad avelad added the priority: P3 Useful but not urgent label Nov 29, 2023
avelad pushed a commit that referenced this issue Nov 29, 2023
Robloche pushed a commit to Robloche/shaka-player that referenced this issue Nov 30, 2023
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jan 28, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jan 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants