Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tizen 6.5: when playing HLS, video stuck while switch between stereo and surround audio #7595

Closed
Itsysho opened this issue Nov 14, 2024 · 12 comments · Fixed by #7700 · May be fixed by #7597
Closed

Tizen 6.5: when playing HLS, video stuck while switch between stereo and surround audio #7595

Itsysho opened this issue Nov 14, 2024 · 12 comments · Fixed by #7700 · May be fixed by #7597
Assignees
Labels
platform: Tizen Issues affecting Tizen priority: P1 Big impact or workaround impractical; resolve before feature release type: bug Something isn't working correctly
Milestone

Comments

@Itsysho
Copy link

Itsysho commented Nov 14, 2024

Have you read the FAQ and checked for duplicate open issues?
Yes.

If the problem is related to FairPlay, have you read the tutorial?

Not related, the video doesn't protection.

What version of Shaka Player are you using?

4.11.4

Can you reproduce the issue with our latest release version?
I'm not in the lab with Tizen 6.5 TV, will try it when I can.

Can you reproduce the issue with the latest code from main?
Same as above.

Are you using the demo app or your own custom app?
My custom app

If custom app, can you reproduce the issue using our demo app?
Also reproduced in my custom app, I tried to fix by

player.selectAudioLanguage(
      activeTrack.language,
      undefined,
      activeTrack.channelsCount,
    )

or

player.selectVariantsByLabel(activeTrack.label)

It could be fix with workaround

player.selectAudioLanguage(activeTrack.language)
player.configure("preferredAudioChannelCount", targetLanguage.channelsCount)
player.reload()

What browser and OS are you using?
Tizen 8.0 / Chromium 108
It also happen Tizen 6.5 / Chromium 85 and Tizen 7.0 / Chromium.

userAgent: Mozilla/5.0 (SMART-TV; Linux; Tizen 8.0) AppleWebKit/537.36 (KHTML, like Gecko) SamsungBrowser/7.0 Chrome/108.0.5359.1 TV Safari/537.36

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?

#EXT-X-MEDIA:TYPE=AUDIO,URI="",GROUP-ID="audio-AACL-127",LANGUAGE="ja",NAME="Japanese",DEFAULT=YES,AUTOSELECT=YES,CHANNELS="2"
#EXT-X-MEDIA:TYPE=AUDIO,URI="",GROUP-ID="audio-AC-3-384",LANGUAGE="und",NAME="Undetermined",DEFAULT=YES,AUTOSELECT=YES,CHANNELS="6"

What configuration are you using? What is the output of player.getNonDefaultConfiguration()?

{
  "manifest": {
    "retryParameters": {
      "maxAttempts": 6
    },
    "dash": {
      "ignoreSuggestedPresentationDelay": true
    }
  },
  "streaming": {
    "safeSeekOffset": 0,
    "autoLowLatencyMode": true,
    "preferNativeHls": true
  }
}

What did you do?
On a device that supports surround sound:

  • Load a stream that contains both stereo and surround audio renditions.
  • Switch between stereo and surround audio.
  • Player stuck.

What did you expect to happen?

  • Play normally.

What actually happened?

  • Player stuck.

Are you planning send a PR to fix it?
Yes, let's find the cause.

@Itsysho Itsysho added the type: bug Something isn't working correctly label Nov 14, 2024
@avelad
Copy link
Member

avelad commented Nov 14, 2024

What value of mediaSource.codecSwitchingStrategy are you using? Maybe RELOAD?

@avelad avelad added the platform: Tizen Issues affecting Tizen label Nov 14, 2024
@shaka-bot shaka-bot added this to the v4.13 milestone Nov 14, 2024
@tykus160
Copy link
Member

@avelad on Tizen 6 shaka uses reload by default.
This is probably caused by #7555

@avelad
Copy link
Member

avelad commented Nov 19, 2024

Duplicated of #7555

@avelad avelad closed this as completed Nov 19, 2024
@avelad avelad added status: duplicate A duplicate of another issue; should be closed after linking to the original issue and removed type: bug Something isn't working correctly platform: Tizen Issues affecting Tizen labels Nov 19, 2024
@avelad avelad removed this from the v4.13 milestone Nov 19, 2024
@Itsysho
Copy link
Author

Itsysho commented Nov 25, 2024

We could reproduce the issue in shaka 4.11.14 which is #7555 check in version and shaka 4.12.2 demo page.

@avelad
Copy link
Member

avelad commented Nov 25, 2024

@tykus160 can you review it? Thanks!

@avelad avelad reopened this Nov 25, 2024
@tykus160
Copy link
Member

@Itsysho could share a manifest URL?

@tykus160 tykus160 added type: bug Something isn't working correctly priority: P1 Big impact or workaround impractical; resolve before feature release and removed status: duplicate A duplicate of another issue; should be closed after linking to the original issue labels Nov 28, 2024
@tykus160 tykus160 self-assigned this Nov 28, 2024
@shaka-bot shaka-bot added this to the v4.13 milestone Nov 28, 2024
@tykus160 tykus160 added the platform: Tizen Issues affecting Tizen label Nov 28, 2024
@tykus160
Copy link
Member

@Itsysho I can confirm I'm able to reproduce the issue. It seems fix prepared in #7630 even worsens the codec switch journey on Tizen. I'm working on reverting the fix and preparing better solution.

@Iragne
Copy link
Contributor

Iragne commented Dec 3, 2024

Hello can it be link to PS5 issue to ?

@tykus160
Copy link
Member

tykus160 commented Dec 3, 2024

@Iragne it's very likable. There's a draft PR of mine, I'm testing it mainly on Tizen & Chromecast now, but if you have a capability to make a draft run with this on PS5, that would be great!

@Iragne
Copy link
Contributor

Iragne commented Dec 3, 2024

I will share to the team yes we will do

@Iragne
Copy link
Contributor

Iragne commented Dec 7, 2024

FYI we are testing it this week and next week with long playback our testing will be on ps5 and we will force a lot of quality change and seek back and forward out of the buffer.
the current testing phase with this + this #7723 is really promising

@Iragne
Copy link
Contributor

Iragne commented Dec 11, 2024

@avelad and @tykus160 this fix is making a huge improvement on cc devices. We will run it in production shortly.

Thanks so much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: Tizen Issues affecting Tizen priority: P1 Big impact or workaround impractical; resolve before feature release type: bug Something isn't working correctly
Projects
None yet
5 participants