Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Upload coverage report for PR and nightly tests #4390

Merged
merged 2 commits into from
Aug 12, 2022

Conversation

joeyparrish
Copy link
Member

@joeyparrish joeyparrish commented Aug 5, 2022

This will attach a code coverage report to PRs and to nightly tests,
both specifically from Chrome on Linux. Reports will be attached to
workflow runs whether or not the tests pass.

@joeyparrish
Copy link
Member Author

This needs more work. I'm testing the workflow change on the PR, though, so I'm going to leave it active while I make changes.

@joeyparrish joeyparrish force-pushed the coverage branch 4 times, most recently from 0d19a21 to 55b5ead Compare August 6, 2022 04:41
@joeyparrish joeyparrish changed the title ci: Upload coverage report ci: Upload coverage report for PR and nightly tests Aug 6, 2022
@joeyparrish joeyparrish force-pushed the coverage branch 3 times, most recently from 1c4c516 to 3a160ec Compare August 6, 2022 19:49
@avelad avelad added the type: CI An issue with our continuous integration tests label Aug 9, 2022
@joeyparrish joeyparrish force-pushed the coverage branch 4 times, most recently from d901b45 to 0caa12d Compare August 10, 2022 22:53
@joeyparrish joeyparrish changed the title ci: Upload coverage report for PR and nightly tests test: Upload coverage report for PR and nightly tests Aug 10, 2022
@joeyparrish joeyparrish force-pushed the coverage branch 2 times, most recently from 0be9821 to 03fffec Compare August 10, 2022 23:32
@joeyparrish
Copy link
Member Author

This is working now! PTAL.

This will attach a code coverage report to PRs and to nightly tests,
both specifically from Chrome on Linux.  Reports will be attached to
workflow runs whether or not the tests pass.
An easier format with more useful data for eventual incremental coverage data.
@joeyparrish
Copy link
Member Author

Ping! Please take a look. I'd love to start collecting coverage data for our project health metrics.

@joeyparrish joeyparrish merged commit 94b14dc into shaka-project:main Aug 12, 2022
@joeyparrish joeyparrish deleted the coverage branch August 12, 2022 17:56
joeyparrish added a commit to joeyparrish/shaka-player that referenced this pull request Aug 13, 2022
…4390)

This will attach a code coverage report to PRs and to nightly tests,
both specifically from Chrome on Linux.  Reports will be attached to  
workflow runs whether or not the tests pass.
joeyparrish added a commit that referenced this pull request Aug 16, 2022
This will attach a code coverage report to PRs and to nightly tests,
both specifically from Chrome on Linux.  Reports will be attached to  
workflow runs whether or not the tests pass.
joeyparrish added a commit that referenced this pull request Aug 16, 2022
This will attach a code coverage report to PRs and to nightly tests,
both specifically from Chrome on Linux.  Reports will be attached to  
workflow runs whether or not the tests pass.
joeyparrish added a commit that referenced this pull request Aug 16, 2022
This will attach a code coverage report to PRs and to nightly tests,
both specifically from Chrome on Linux.  Reports will be attached to  
workflow runs whether or not the tests pass.
joeyparrish added a commit that referenced this pull request Aug 16, 2022
This will attach a code coverage report to PRs and to nightly tests,
both specifically from Chrome on Linux.  Reports will be attached to  
workflow runs whether or not the tests pass.
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: CI An issue with our continuous integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants