test: Test StringUtils both with and without TextDecoder #4405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the TextDecoder fallback is only used on some devices, those code paths were not tested on other platforms. This makes the StringUtil tests execute both with and without TextDecoder.
joeyparrish
force-pushed
the
text-decoder-coverage
branch
from
2c0f90d to
4e9fdeb
Compare
avelad
approved these changes
Aug 13, 2022
joeyparrish
added a commit
that referenced
this pull request
Aug 16, 2022
Since the TextDecoder fallback is only used on some devices, those code paths were not tested on other platforms. This makes the StringUtil tests execute both with and without TextDecoder.
joeyparrish
added a commit
that referenced
this pull request
Aug 16, 2022
Since the TextDecoder fallback is only used on some devices, those code paths were not tested on other platforms. This makes the StringUtil tests execute both with and without TextDecoder.
joeyparrish
added a commit
that referenced
this pull request
Aug 16, 2022
Since the TextDecoder fallback is only used on some devices, those code paths were not tested on other platforms. This makes the StringUtil tests execute both with and without TextDecoder.
joeyparrish
added a commit
that referenced
this pull request
Aug 16, 2022
Since the TextDecoder fallback is only used on some devices, those code paths were not tested on other platforms. This makes the StringUtil tests execute both with and without TextDecoder.
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the TextDecoder fallback is only used on some devices, those
code paths were not tested on other platforms. This makes the
StringUtil tests execute both with and without TextDecoder.