Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(HLS): Support AES-128 in init segment according the RFC #5677

Merged
merged 1 commit into from
Sep 25, 2023
Merged

fix(HLS): Support AES-128 in init segment according the RFC #5677

merged 1 commit into from
Sep 25, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Sep 25, 2023

Fixes #5667

@avelad
Copy link
Member Author

avelad commented Sep 25, 2023

This change depends on 96ae7f2 so it's not possible cherry pick it to previous branches

@avelad avelad added type: bug Something isn't working correctly component: HLS The issue involves Apple's HLS manifest format priority: P1 Big impact or workaround impractical; resolve before feature release labels Sep 25, 2023
@avelad avelad added this to the v4.5 milestone Sep 25, 2023
@avelad avelad merged commit 806d91a into shaka-project:main Sep 25, 2023
19 of 21 checks passed
@shaka-bot shaka-bot mentioned this pull request Sep 25, 2023
Closed
@avelad avelad deleted the hls-aes-128 branch September 25, 2023 10:26
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 83.87%

@joeyparrish
Copy link
Member

This change depends on 96ae7f2 so it's not possible cherry pick it to previous branches

It seems worth reimplementing in maintained branches if possible. This bug would affect all those branches.

@avelad
Copy link
Member Author

avelad commented Sep 26, 2023 •
edited
Loading

@joeyparrish Then you have to migrate the changes of two files from 96ae7f2

  • lib/media/segment_reference.js
  • lib/media/streaming_engine.js

joeyparrish added a commit that referenced this pull request Oct 4, 2023
@joeyparrish
chore: Partial cherry-pick and backport of #5656
3dd413d 
This is parts of #5656 cherry-picked and backported to support the cherry-pick of #5677, which fixes a bug in HLS.
joeyparrish pushed a commit that referenced this pull request Oct 4, 2023
@avelad @joeyparrish
fix(HLS): Support AES-128 in init segment according the RFC (#5677)
42784a9 
Fixes #5667

Backported to v4.4.x
@shaka-bot shaka-bot mentioned this pull request Oct 4, 2023
Merged
joeyparrish added a commit that referenced this pull request Oct 4, 2023
@joeyparrish
chore: Partial cherry-pick and backport of #5656
a7d2f9b 
This is parts of #5656 cherry-picked and backported to support the cherry-pick of #5677, which fixes a bug in HLS.

Backported to v4.3.x
joeyparrish pushed a commit that referenced this pull request Oct 4, 2023
@avelad @joeyparrish
fix(HLS): Support AES-128 in init segment according the RFC (#5677)
d30c571 
Fixes #5667

Backported to v4.3.x
@shaka-bot shaka-bot mentioned this pull request Oct 4, 2023
Merged
joeyparrish added a commit that referenced this pull request Oct 4, 2023
@joeyparrish
chore: Partial cherry-pick and backport of #5656
abed086 
This is parts of #5656 cherry-picked and backported to support the cherry-pick of #5677, which fixes a bug in HLS.
joeyparrish pushed a commit that referenced this pull request Oct 4, 2023
@avelad @joeyparrish
fix(HLS): Support AES-128 in init segment according the RFC (#5677)
9d50f01 
Fixes #5667

Backported to v4.4.x
@shaka-bot shaka-bot mentioned this pull request Oct 4, 2023
Merged
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Nov 24, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Nov 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

@littlespex littlespex Awaiting requested review from littlespex

Assignees
No one assigned
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

Bug - shaka-player don't play AES-128 HLS according the RFC
4 participants
@avelad @shaka-bot @joeyparrish @theodab