Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: seeking in segment timeline returns incorrect index #5716

Merged
merged 2 commits into from
Oct 3, 2023
Merged

fix: seeking in segment timeline returns incorrect index #5716

merged 2 commits into from
Oct 3, 2023

Conversation

littlespex
Copy link
Contributor

Resolves #5664

joeyparrish
joeyparrish requested changes Oct 3, 2023
View reviewed changes
Copy link
Member

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a regression test?

@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad added type: bug Something isn't working correctly priority: P1 Big impact or workaround impractical; resolve before feature release component: DASH The issue involves the MPEG DASH manifest format labels Oct 3, 2023
@avelad avelad added this to the v4.5 milestone Oct 3, 2023
@littlespex
Copy link
Contributor Author

A regression test has been added.

@littlespex littlespex requested a review from joeyparrish October 3, 2023 21:00
@joeyparrish
Copy link
Member

Thanks!

@joeyparrish joeyparrish merged commit c02ccee into shaka-project:main Oct 3, 2023
19 checks passed
@shaka-bot shaka-bot mentioned this pull request Oct 3, 2023
Closed
@avelad avelad mentioned this pull request Oct 4, 2023
Closed
joeyparrish pushed a commit that referenced this pull request Oct 4, 2023
@littlespex @joeyparrish
fix: seeking in segment timeline returns incorrect index (#5716)
ba51991 
Resolves #5664
@shaka-bot shaka-bot mentioned this pull request Oct 4, 2023
Merged
joeyparrish pushed a commit that referenced this pull request Oct 4, 2023
@littlespex @joeyparrish
fix: seeking in segment timeline returns incorrect index (#5716)
15b8da0 
Resolves #5664
@shaka-bot shaka-bot mentioned this pull request Oct 4, 2023
Merged
Robloche pushed a commit to Robloche/shaka-player that referenced this pull request Nov 30, 2023
@littlespex
fix: seeking in segment timeline returns incorrect index (shaka-proje…
8c4e231 
…ct#5716)

Resolves shaka-project#5664
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Dec 3, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Dec 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@avelad avelad avelad approved these changes

@joeyparrish joeyparrish joeyparrish approved these changes

Assignees
No one assigned
Labels
component: DASH The issue involves the MPEG DASH manifest format priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

Seeking not working as expected on certain multi period DASH streams in 4.4.x
5 participants
@littlespex @shaka-bot @joeyparrish @avelad @theodab