-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ID3): decode APIC frames #5857
Conversation
Incremental code coverage: 88.00% |
@pszemus can you provide a sample stream to test the code? Thanks! |
Here's a sample live HLS stream: https://stream-cdn-1.open.fm/OFM18/ngrp:standard/playlist.m3u8 with ID3 frames inserted at each song change: TIT2, TLEN, WOAF and APIC In this stream, each APIC frame contains the following informationf:
Above should map to the following metadata object being thrown:
and it does, according to unit tests I wrote. What bothers me is why Shaka Player replaces the
and the result of the parsed APIC frame:
|
@pszemus I fixed the problem. Thanks for your PR! |
Since the official ID3 site (https://id3.org) is not available, I used a mirror (https://mutagen-specs.readthedocs.io/en/latest/id3/id3v2.4.0-frames.html#apic) to implement the decoding of APIC frames. --------- Co-authored-by: Álvaro Velad Galván <ladvan91@hotmail.com>
Since the official ID3 site (https://id3.org) is not available, I used a mirror (https://mutagen-specs.readthedocs.io/en/latest/id3/id3v2.4.0-frames.html#apic) to implement the decoding of APIC frames.