Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(WebVTT): Fix support for line vertical alignment #5945

Merged
merged 6 commits into from
Dec 4, 2023
Merged

fix(WebVTT): Fix support for line vertical alignment #5945

merged 6 commits into from
Dec 4, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Nov 28, 2023 •
edited
Loading

Fixes #4446

@avelad avelad marked this pull request as draft November 28, 2023 15:20
@avelad avelad added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround component: WebVTT The issue involves WebVTT subtitles specifically labels Nov 28, 2023
@avelad avelad added this to the v5.0 milestone Nov 28, 2023
@avelad avelad force-pushed the webvtt-line-number branch from 5af5380 to 8d07731 Compare November 28, 2023 15:25
gkatsev
gkatsev approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better hack than before 😆

lib/text/ui_text_displayer.js Show resolved Hide resolved
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 75.00%

@avelad
Copy link
Member Author

avelad commented Dec 3, 2023

@theodab I'll update the screenshots after merge #5975

@avelad avelad marked this pull request as ready for review December 3, 2023 20:09
@avelad avelad marked this pull request as draft December 3, 2023 20:09
@avelad avelad marked this pull request as ready for review December 4, 2023 07:43
@avelad avelad merged commit 9f5e461 into shaka-project:main Dec 4, 2023
11 of 15 checks passed
@shaka-bot shaka-bot mentioned this pull request Dec 4, 2023
Merged
avelad added a commit that referenced this pull request Dec 4, 2023
@avelad
fix(WebVTT): Fix support for line vertical alignment (#5945)
ce3a2f7 
Fixes #4446
@shaka-bot shaka-bot mentioned this pull request Dec 4, 2023
Merged
@avelad avelad deleted the webvtt-line-number branch December 4, 2023 09:35
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Feb 2, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gkatsev gkatsev gkatsev approved these changes

@theodab theodab theodab approved these changes

Assignees
No one assigned
Labels
component: WebVTT The issue involves WebVTT subtitles specifically priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

shaka-ui: Subtitles vertical alignment
4 participants
@avelad @shaka-bot @gkatsev @theodab