fix(DASH): Fix playback of some DASH with multiple periods #7519
Conversation
…ect#7516) With this change, closeSegmentIndex() of all streams of a removed period are defered in StreamingEngine.onUpdate_() Fixes shaka-project#7516
Provide an interface between StreamEngine and ManifestParser to defer the call of closeStreamIndex durring the update of segments instead the update of the manifest. Fix eslint / jsdoc
|
Incremental code coverage: 98.08% |
ncocaign
changed the title
avelad
added
type: bug
avelad
changed the title
| @@ -114,6 +114,7 @@ | |||
| +../../lib/util/public_promise.js | |||
| +../../lib/util/state_history.js | |||
| +../../lib/util/stats.js | |||
| +../../lib/util/segment_index.js | |||
There was a problem hiding this comment.
There is already lib/media/segment_index, 2 same file names in different spaces might be confusing
| /** | ||
| * provide CloseSegmentIndexRegister | ||
| * @param {shaka.util.CloseSegmentIndexRegister} register | ||
| * @exportDoc | ||
| */ | ||
| setCloseSegmentIndexRegister(register) {} |
There was a problem hiding this comment.
If we want to add new method to publicly exposed interface, it will need to be documented better.
Preferably though, we shouldn't add new method but try to look for other solutions (maybe callback in shaka.extern.ManifestParser.PlayerInterface?)
| * Handles deferred releases of old SegmentIndexes | ||
| * content type from a previous update. | ||
| * @export |
There was a problem hiding this comment.
It's not a part of public interface, don't export it
| * Removes all SegmentReferences that end before the given time. | ||
| * @export | ||
| */ | ||
| evictAll() { |
There was a problem hiding this comment.
If it was exported, it should be defined in shaka.extern.SegmentIndex.
avelad
added
the
status: waiting on response
|
thanks for the feedback, I'm making the various modifications. |
shaka-bot
removed
the
status: waiting on response
With this change, closeSegmentIndex() of all streams of a removed period are defered in StreamingEngine.onUpdate_()
Fixes #7516