feat: add support for multiple robustness levels in drm #7753
+513
−166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkatsev
changed the title
|
Incremental code coverage: 94.15% |
tykus160
added
type: enhancement
avelad
requested changes
Dec 12, 2024
demo/main.js
Outdated
| @@ -949,10 +949,10 @@ shakaDemo.Main = class { | |||
| advanced[drmSystem] = shakaDemo.Main.defaultAdvancedDrmConfig(); | |||
| } | |||
| if ('videoRobustness' in params) { | |||
| advanced[drmSystem].videoRobustness = params['videoRobustness']; | |||
| advanced[drmSystem].videoRobustness = [params['videoRobustness']]; | |||
There was a problem hiding this comment.
Please update the Demo in order to support an array (using ,). See preferredVideoCodecs as example
theodab
previously requested changes
Dec 12, 2024
gkatsev
commented
Dec 12, 2024
demo/main.js
Outdated
| } | ||
| } | ||
|
|
||
| this.configure('drm.advanced', advanced); |
There was a problem hiding this comment.
without this, it would read the advanced settings from the hash, but it would never actually set it back on the player.
tykus160
approved these changes
Dec 13, 2024
|
@gkatsev can you rebase your PR? Thanks! |
avelad
requested changes
Dec 20, 2024
Co-authored-by: Wojciech Tyczyński <tykus160@gmail.com>
gkatsev
force-pushed
the
multiple-robustness
branch
from
ccfa1c4 to
f4c5db1
Compare
avelad
added
priority: P3
avelad
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
drm.advanced.videoRobustnessandaudioRobustnessconfig options from a string to an array of strings. Internally, in the drm engine, this gets expanded into an array ofDrmInfoswhich have those values as strings.Best way to review this change is with whitespace turned off in the diff options.