Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Ads): Expose the interstitial player #7793

Merged
merged 1 commit into from
Dec 23, 2024
Merged

feat(Ads): Expose the interstitial player #7793

merged 1 commit into from
Dec 23, 2024
+28 −2

Conversation

avelad
Copy link
Member

@avelad avelad commented Dec 20, 2024

Close #7763

@avelad avelad added type: enhancement New feature or request component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P3 Useful but not urgent labels Dec 20, 2024
@avelad avelad added this to the v4.13 milestone Dec 20, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 50.00%

@avelad avelad merged commit 6783ce0 into shaka-project:main Dec 23, 2024
22 of 23 checks passed
@avelad avelad deleted the player-get-interstitials branch December 23, 2024 08:40
@shaka-bot shaka-bot mentioned this pull request Dec 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

@theodab theodab Awaiting requested review from theodab

@tykus160 tykus160 Awaiting requested review from tykus160

Assignees
No one assigned
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P3 Useful but not urgent type: enhancement New feature or request
Projects
None yet
Milestone
v4.13
Development

Successfully merging this pull request may close these issues.

Can headers be added to the fetched media file when adding a custom interstitial?
3 participants
@avelad @shaka-bot @joeyparrish