Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: optimize for import #3

Merged
merged 7 commits into from
Jul 1, 2019
Merged

refactor: optimize for import #3

merged 7 commits into from
Jul 1, 2019

Conversation

zvuc
Copy link
Collaborator

@zvuc zvuc commented Jun 26, 2019

  • Adds new keyframes files only including keyframes and animation names as mixins. This can be useful when trying to import individual animations and keyframes only when needed.
  • Refactors module files to import keyframe files instead of inlining directly. Compiled result will be the same so no risk of breaking backward compatibility.
  • Removes .animated.infinite class because Tuesday does not serve any infinite-looping type animations.

@zvuc zvuc force-pushed the optimize-for-import branch 3 times, most recently from 1344281 to 3e6e229 Compare June 27, 2019 07:15
@zvuc zvuc force-pushed the optimize-for-import branch from 3e6e229 to 547568f Compare June 27, 2019 08:01
@zvuc zvuc marked this pull request as ready for review June 27, 2019 08:16
@zvuc zvuc requested a review from log2-hwan June 27, 2019 08:16
@zvuc zvuc changed the title Optimize for import refactor: optimize for import Jun 28, 2019
@zvuc zvuc merged commit 4ab6aba into master Jul 1, 2019
@zvuc zvuc deleted the optimize-for-import branch July 1, 2019 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants