Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not adding whitespace between words? #53

Closed
JSteunou opened this issue Aug 11, 2017 · 3 comments · May be fixed by #56
Closed

Why not adding whitespace between words? #53

JSteunou opened this issue Aug 11, 2017 · 3 comments · May be fixed by #56

Comments

@JSteunou
Copy link

JSteunou commented Aug 11, 2017

examples are like thousand words

const cap = require('lodash/capitalize');

bel`<p>${cap('hello')} ${cap('world')}!</p>`

will shout HelloWorld! with yo-yoify but Hello World! with bel

This come from https://github.com/shama/yo-yoify/blob/master/lib/appendChild.js#L15

@JSteunou
Copy link
Author

JSteunou commented Aug 11, 2017

Seems to be since #45

If some other people have the same issue you should stay with 3.7.2 as 3.7.3 introduced this breaking change without bumping major.

goto-bus-stop added a commit to goto-bus-stop/shama-yo-yoify that referenced this issue Oct 11, 2017
And closes shama#53

This uses the `bel/appendChild` export introduced by bel v5.1.3.
It's breaking because now you have to have bel installed.
@mantoni
Copy link

mantoni commented May 17, 2018

For anyone coming accross this issue: I was able to use the nanohtml browserify transform as a drop-in replacement for yo-yoify and it doesn't have this issue.

@bcomnes
Copy link
Collaborator

bcomnes commented May 17, 2018

Use nanohtml! Closing. Thanks!

@bcomnes bcomnes closed this as completed May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants