Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
* Fix webpack build process

* Only ignore warning from express
  • Loading branch information
auxves authored and shanalikhan committed Jul 1, 2019
1 parent 7257166 commit 6d6b08e
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 12 deletions.
18 changes: 8 additions & 10 deletions configs/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,12 @@

const path = require("path");
const { CleanWebpackPlugin } = require("clean-webpack-plugin");
const webpack = require("webpack");
const nodeExternals = require("webpack-node-externals");

/** @type WebpackOptions */
const config = {
stats: {
warningsFilter: /Critical dependency: the request of a dependency is an expression/
},
target: "node",
entry: "./src/extension.ts",
output: {
Expand All @@ -33,14 +34,11 @@ const config = {
}
]
},
externals: [
{
vscode: "commonjs vscode",
"vscode-fsevents": "commonjs vscode-fsevents",
"original-fs": "commonjs original-fs"
},
nodeExternals()
],
externals: {
vscode: "commonjs vscode",
"vscode-fsevents": "commonjs vscode-fsevents",
"original-fs": "commonjs original-fs"
},
plugins: [new CleanWebpackPlugin()]
};

Expand Down
3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,6 @@
"node-fetch": "^2.5.0",
"recursive-readdir": "^2.2.2",
"temp": "^0.9.0",
"vscode-chokidar": "^1.6.5",
"webpack-node-externals": "^1.7.2"
"vscode-chokidar": "^1.6.5"
}
}

0 comments on commit 6d6b08e

Please sign in to comment.