Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove manual visx package installation in favour of extension download by CLI #820

Closed
shanalikhan opened this issue Apr 3, 2019 · 0 comments

Comments

@shanalikhan
Copy link
Owner

Remove the previous package download code used to manually send request to url to download and extract the package into the extension directory

As currently install-extension command line method is introduced to install the required extension by vscode team.

@shanalikhan shanalikhan added this to the v3.2.8 milestone Apr 3, 2019
shanalikhan added a commit that referenced this issue Apr 3, 2019
shanalikhan added a commit that referenced this issue Apr 3, 2019
shanalikhan added a commit that referenced this issue Apr 4, 2019
* #806

* prettify custom setting json (#812)

* Fix auto upload (#801)

* Fix auto upload!

* Properly stop watching

* Add synchronous functions

* Move watcher to a new service

* Make a new service for watcher

* Add general ignored items setting for chokidar

* Use globalCommons's autoUploadService instance

* Reset

* Add local settings to ignored files

* Asynchronously get ignored items

* Remove unused import

* Use autoUploadService

* Use the globalCommonService everywhere
Since the autoUploadService is an instance in Commons, using a global
Commons instance will allow everything to use the same instance.

* Stop spamming with extension paths

* Fix to work with async functions

* Add global state to ignored files

* Add .DS_Store and sync.lock

* Start watcher only after downloading has finished

* Inform user that auto upload has started

* #805

* #820

* #820

* #821

* #805

* #823

* Go back to webpack and fix source maps

* Ignore node_modules and some other files (#826)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant