Fix #686

[protiumx]

Extract all the pragma @sync-ignore lines and add them to the beginning of the downloaded settings.
It also fix an issue during the check of the settings as valid JSON.

Note: the settings are formatted with spaces or tabs. Should we normalize the text format or it is up to the user?

#686

[shanalikhan]

Should we normalize the text format or it is up to the user?

By normalizing you mean, format the JSON, right? Yes if the JSON is validated we can normalise the text.

[protiumx]

I mean, if the text is indented with mixed tabs and spaces, we should upload/download the content indented only with tabs or only with spaces? This has no issues with the implementation, I asked because user can have the following format:

{
    setting1: true,
setting2:true,
              setting3:true
}

And if we normalize the indent to get a clean view of the settings it will be saved as

// two spaces ident
{
  setting1: true,
  setting2:true,
  setting3:true
}

My question is if that could be a feature of the sync extension or user should care if the settings are correctly indented or not, since they have to manually add the pragmas on the settings.json file rather than using the integrated settings view. VS Code has no issue parsing de JSON no matter how it is indented.

Anyway, this PR fix the bug with ignored settings. Maybe my question is out of the context of this bug. You can merge it if you don't see something to improve.

[shanalikhan]

You can merge it if you don't see something to improve.

So i guess its ready, but i found its closed PR. i have reopened this and merged this.

Yes that would be a good improvement regarding normalization. When you have time feel free to improve where required.

Thank you for your contributions so far!

[protiumx]

Yes! Sorry, still learning how to do PRs haha.
I was thinking, maybe users have comments or some custom things going on in theirs settings.json files. Maybe you should ask to the users if it would be something useful for them that code sync format the files or it is just irrelevant for them.

You are welcome! When I have free time I will look up for more improvements.