[Done] Improve compatibility with different versions of VSCode #859

auxves · 2019-04-23T00:29:04Z

Short description of what this resolves:

This PR simplifies finding the code configuration folders and uses the API to install/uninstall extensions.

Changes proposed in this pull request:

Find Code folder using the globalStoragePath and by traversing 3 directories up
Find Extensions folder by getting a random extension and traversing up 1 directory
Use VSCode API to install/uninstall extensions

Fixes: #668

How Has This Been Tested?

I have tested this PR with the OSS version, VSCodium portable, and the official version (on Manjaro), and with the official version on Windows.

Checklist:

I have read the contribution guidelines.

Progress:

Install extensions using API
Uninstall extensions using API
Get folders properly

enums.ts ---- Allow for setting os type with less code environmentPath.ts ---- Find code folder and extensions folder more efficiently Get OS type more efficiently settings.ts ---- Ignore all state files sync.ts ---- Adapt for changes in pluginService pluginService.ts ---- Use vscode command to install extensions Clean up code and simplify names

shanalikhan · 2019-04-23T13:46:14Z

Thanks for the work so far.

I need people using OSS Code to test it

lets complete this PR, after code review we will ask the users there to test by providing the custom build in that thread for OSS version before merging.

Also please comment this code as of now instead of removing
https://github.com/shanalikhan/code-settings-sync/pull/859/files#diff-09ef59e49c66636eacf529be73517d36L67

I will suggest you to comment each of the old code in each functions in that function code comment block for the environmentPath file only. We will remove it later.
Alot of users sent PR fixing the paths for code versions, so it might help us in future and we will remove the comments later when not required.

nadiamoe · 2019-04-29T13:56:12Z

VSCodium user here, can you provide some instructions so I can test this? I'm pretty new to the VSC ecosystem, so if you could provide a prebuilt version of the extension and how to install it would be great. Thanks!

auxves · 2019-04-29T22:59:57Z

@roobre Here is a prebuilt version of this PR: https://cdn.discordapp.com/attachments/549007146868539408/572557047439032330/code-settings-sync-3.2.9.vsix

can you provide some instructions so I can test this?

Instructions can be found here on how to install the VSIX file: https://code.visualstudio.com/docs/editor/extension-gallery#_install-from-a-vsix

nadiamoe · 2019-04-30T20:06:24Z

Done, but it's still not working for me on VSCodium. The upload is just fine, but after entering the token and gist id on the other side, and clicking Yes in the extension install prompt, nothing happens. Where can I can find a detailed log of why is it failing? Maybe that would be helpful.

auxves · 2019-04-30T22:10:32Z

@roobre are you getting anything in the console? You can find it under Help -> Toggle Developer Tools.

nadiamoe · 2019-05-01T11:24:31Z

So, strangely, I tried to reproduce everything with the console open and now it is working (extensions are correctly installed). Thanks!

However, whenever I try to update the changes on the receiving side, a new gist is created instead of updating the one that was used to sync in the same place. This does not happen on the VSC instance that first updated the settings.

auxves · 2019-05-03T23:45:50Z

@roobre Here is an updated version with some issues with extension installation hopefully fixed. If you could test it, that would be great!
https://cdn.discordapp.com/attachments/549007146868539408/574452219064352768/code-settings-sync-3.2.9.vsix
Edit: updated with many many fixes

nadiamoe · 2019-05-06T08:41:55Z

Should I test the current link or wait for a more recent version with the new commits applied? Thanks!

samirfor · 2019-05-17T14:20:56Z

@roobre Here is an updated version with some issues with extension installation hopefully fixed. If you could test it, that would be great!
https://cdn.discordapp.com/attachments/549007146868539408/574452219064352768/code-settings-sync-3.2.9.vsix
Edit: updated with many many fixes

I think it's okay now. Thanks.

auxves · 2019-05-19T01:43:55Z

@roobre sorry for the late reply. Can you try this version? Installing extensions should work, but uninstallation has yet to be implemented. Thanks! https://cdn.discordapp.com/attachments/549007146868539408/576214978931982336/code-settings-sync-3.2.9.vsix

nadiamoe · 2019-05-26T09:49:12Z

@arnohovhannisyan I have done a simple test and seems to be working good so far in VSCodium.
Made an initial upload on host A, downloaded to host B, made changes on host B, and gitst seems to be updated accordingly.
Tomorrow I'll test to see if downloading changes on host A again works properly, but for now it seems quite nice.

Thanks!

Update: Seems to be working good on the other end too!

auxves · 2019-06-06T21:39:55Z

@shanalikhan Microsoft has released the May 2019 update, so this PR is complete and ready to be merged.

shanalikhan

Please fix the required things. Code review is done.
I will test it and merge it in the coming days.

src/environmentPath.ts

src/service/pluginService.ts

src/sync.ts

src/service/pluginService.ts

auxves · 2019-06-06T23:18:36Z

@shanalikhan Are you happy with my changes? Do you have any other requests for changes?

shanalikhan · 2019-06-07T09:35:01Z

Thanks. Merged.
You can test on v3.3.0.
I will test it also alongwith other PR and release upcoming version soon.

shanalikhan · 2019-06-07T10:01:16Z

Okay this is some initial observation.

Got this error while it tried to remove.
This is in the Output Pane. If you observe the logs, it didnt wrote the added extensions in the output pane even after installing and didnt show anything on removed extensions.

Realtime Extension Download Summary
--------------------
TOTAL EXTENSIONS : 8



[x] - EXTENSION: rainbow-brackets INSTALLED.
      1 OF 8 INSTALLED


[x] - EXTENSION: path-intellisense INSTALLED.
      2 OF 8 INSTALLED


[x] - EXTENSION: npm-intellisense INSTALLED.
      3 OF 8 INSTALLED


[x] - EXTENSION: vscode-eslint INSTALLED.
      4 OF 8 INSTALLED


[x] - EXTENSION: vscodeintellicode INSTALLED.
      5 OF 8 INSTALLED


[x] - EXTENSION: shades-of-purple INSTALLED.
      6 OF 8 INSTALLED


[x] - EXTENSION: tslint INSTALLED.
      7 OF 8 INSTALLED


[x] - EXTENSION: jshint INSTALLED.
      8 OF 8 INSTALLED

CODE SETTINGS SYNC DOWNLOAD SUMMARY
Version: 3.2.9
--------------------
GitHub Token: xxxxx
GitHub Gist: e86911443d3f81be6a66699603aee6dc
GitHub Gist Type: Secret

Restarting Visual Studio Code may be required to apply color and file icon theme.
--------------------
Files Downloaded:
  extensions.json > extensions.json
  keybindings.json > keybindings.json
  launch.json > launch.json
  locale.json > locale.json
  settings.json > settings.json
  snippets|blade.json > snippets|blade.json
  snippets|c.json > snippets|c.json
  snippets|clojure.json > snippets|clojure.json
  snippets|csharp.json > snippets|csharp.json
  snippets|go.json > snippets|go.json
  snippets|html.json > snippets|html.json
  snippets|javascript.json > snippets|javascript.json
  snippets|javascriptreact.json > snippets|javascriptreact.json
  snippets|php.json > snippets|php.json
  snippets|sass.json > snippets|sass.json
  snippets|test.code-snippets > snippets|test.code-snippets
  vsicons.settings.json > vsicons.settings.json

Extensions Ignored:
  No extensions ignored.

Extensions Removed:

Please open new PR fixing this, linking with this PR and original issue.
:)

shanalikhan · 2019-06-09T12:15:40Z

when do you think you can fix it?

auxves · 2019-06-09T12:31:49Z

@shanalikhan I'll look into it as soon as I can. I'm just a bit busy at the moment.

auxves · 2019-06-10T04:58:25Z

@shanalikhan I can't reproduce this issue on my machine. I have set up a portable version of VSCode and am debugging the extension with it, and everything works. Both removed and added extensions show up correctly.

shanalikhan · 2019-06-10T11:12:21Z

I can't reproduce this issue on my machine

Can you try to throw manually exception regarding "Unable to remove some extensions". and see what happens in that case. Meanwhile i will test again.

auxves · 2019-06-10T11:27:23Z

@shanalikhan Ok, I think I know what's causing some of these problems.

If an error occurs during the deletion process, deletedExtensions is set to an error that is caught by the try-catch. That error doesn't have a forEach method, so an exception is thrown which prevents the added extensions from being printed.

Can you test this version? It should throw the error so we can find out what's causing the deletion to fail.

https://cdn.discordapp.com/attachments/549007146868539408/587603441908580362/code-settings-sync-3.2.9.vsix

shanalikhan · 2019-06-10T11:29:42Z

If an error occurs during the deletion process, deletedExtensions is set to an error that is caught by the try-catch. That error doesn't have a forEach method, so an exception is thrown which prevents the added extensions from being printed.

Exactly.

i will try on home computer where it was not working properly and let you know.

shanalikhan · 2019-06-10T21:25:04Z

Before testing that one, another thing observed.
Please test this line of code on multiple times.

Missing Extension List is incorrect.

Please test on your end. Create new PR with the things you think we can fix and improve caused by this PR. I will let you know more observationsmeanwhile.

See the image

Second Test

Here is the output from the package you have provided.
I have installed one more extension, on download - it should delete that extension but it doesnt.

COMMAND LINE EXTENSION DOWNLOAD SUMMARY
--------------------
Sync : No Extensions needs to be installed.
CODE SETTINGS SYNC DOWNLOAD SUMMARY
Version: 3.2.9
--------------------
GitHub Token: xxx
GitHub Gist: e86911443d3f81be6a66699603aee6dc
GitHub Gist Type: Secret

Restarting Visual Studio Code may be required to apply color and file icon theme.
--------------------
Files Downloaded:
  extensions.json > extensions.json
  keybindings.json > keybindings.json
  launch.json > launch.json
  locale.json > locale.json
  settings.json > settings.json
  snippets|blade.json > snippets|blade.json
  snippets|c.json > snippets|c.json
  snippets|clojure.json > snippets|clojure.json
  snippets|csharp.json > snippets|csharp.json
  snippets|go.json > snippets|go.json
  snippets|html.json > snippets|html.json
  snippets|javascript.json > snippets|javascript.json
  snippets|javascriptreact.json > snippets|javascriptreact.json
  snippets|php.json > snippets|php.json
  snippets|sass.json > snippets|sass.json
  snippets|test.code-snippets > snippets|test.code-snippets

Extensions Ignored:
  No extensions ignored.

Extensions Removed:
  No extensions removed.

Extensions Added:
  No extensions installed.
--------------------
Done.

auxves · 2019-06-11T08:09:42Z

@shanalikhan My new PR (#907) should fix both of these issues. I have tested them and they work just as expected.

tunnckoCore · 2019-06-26T14:18:39Z

So, now 3.3.1 is officially released and published, it should work. : )

shanalikhan · 2019-06-27T12:19:47Z

@tunnckoCore Yes Settings Sync supports all OSS versions now.
Let us know if you find any problem.

auxves added 2 commits April 22, 2019 17:23

Install extensions in order

9c0800e

shanalikhan added this to the v3.3.0 milestone Apr 23, 2019

shanalikhan added the bug 🐛 label Apr 23, 2019

Comment legacy code instead of deleting it

154de9e

Fix extension install

54ed805

auxves added 4 commits May 3, 2019 19:34

Fix issue with extensions always being deleted

20f7f58

Get code path more efficiently

f5910f2

Make sure to escape spaces in cli path

5ae3157

Fix issues with portable builds

0fe4675

auxves mentioned this pull request May 5, 2019

Not working with OSS code #668

Closed

Support Windows and certain editions

9c9c55f

auxves mentioned this pull request May 5, 2019

Allow for uninstalling extensions using the API microsoft/vscode#73309

Closed

Improve method for finding extension folder

398d9c1

Start using API for installation

0de3a9d

Prepare for new API command

7e904e7

auxves changed the title ~~[WIP] Add more support for OSS versions of code~~ [Almost Done] Add more support for OSS versions of code May 27, 2019

auxves added 2 commits May 27, 2019 21:25

Get ready for new API command

1166b67

Fix issue with installation

865dc71

stripedpajamas mentioned this pull request May 31, 2019

code-settings-sync extension cannot sync and install extensions on linux build VSCodium/vscodium#180

Closed

auxves changed the title ~~[Almost Done] Add more support for OSS versions of code~~ [Almost Done] Improve compatibility with different versions of VSCode Jun 4, 2019

auxves changed the title ~~[Almost Done] Improve compatibility with different versions of VSCode~~ [Done] Improve compatibility with different versions of VSCode Jun 6, 2019

shanalikhan requested changes Jun 6, 2019

View reviewed changes

Commit requested changes

6437c25

shanalikhan merged commit f12f8ed into shanalikhan:v3.3.0 Jun 7, 2019

auxves deleted the fix-oss branch June 19, 2019 11:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Done] Improve compatibility with different versions of VSCode #859

[Done] Improve compatibility with different versions of VSCode #859

auxves commented Apr 23, 2019 •

edited

Loading

shanalikhan commented Apr 23, 2019

nadiamoe commented Apr 29, 2019

auxves commented Apr 29, 2019

nadiamoe commented Apr 30, 2019

auxves commented Apr 30, 2019

nadiamoe commented May 1, 2019

auxves commented May 3, 2019 •

edited

Loading

nadiamoe commented May 6, 2019

samirfor commented May 17, 2019

auxves commented May 19, 2019

nadiamoe commented May 26, 2019 •

edited

Loading

auxves commented Jun 6, 2019

shanalikhan left a comment

auxves commented Jun 6, 2019

shanalikhan commented Jun 7, 2019

shanalikhan commented Jun 7, 2019

shanalikhan commented Jun 9, 2019

auxves commented Jun 9, 2019

auxves commented Jun 10, 2019

shanalikhan commented Jun 10, 2019

auxves commented Jun 10, 2019

shanalikhan commented Jun 10, 2019

shanalikhan commented Jun 10, 2019 •

edited

Loading

auxves commented Jun 11, 2019

tunnckoCore commented Jun 26, 2019

shanalikhan commented Jun 27, 2019

[Done] Improve compatibility with different versions of VSCode #859

[Done] Improve compatibility with different versions of VSCode #859

Conversation

auxves commented Apr 23, 2019 • edited Loading

Short description of what this resolves:

Changes proposed in this pull request:

How Has This Been Tested?

Checklist:

Progress:

shanalikhan commented Apr 23, 2019

nadiamoe commented Apr 29, 2019

auxves commented Apr 29, 2019

nadiamoe commented Apr 30, 2019

auxves commented Apr 30, 2019

nadiamoe commented May 1, 2019

auxves commented May 3, 2019 • edited Loading

nadiamoe commented May 6, 2019

samirfor commented May 17, 2019

auxves commented May 19, 2019

nadiamoe commented May 26, 2019 • edited Loading

auxves commented Jun 6, 2019

shanalikhan left a comment

Choose a reason for hiding this comment

auxves commented Jun 6, 2019

shanalikhan commented Jun 7, 2019

shanalikhan commented Jun 7, 2019

shanalikhan commented Jun 9, 2019

auxves commented Jun 9, 2019

auxves commented Jun 10, 2019

shanalikhan commented Jun 10, 2019

auxves commented Jun 10, 2019

shanalikhan commented Jun 10, 2019

shanalikhan commented Jun 10, 2019 • edited Loading

auxves commented Jun 11, 2019

tunnckoCore commented Jun 26, 2019

shanalikhan commented Jun 27, 2019

auxves commented Apr 23, 2019 •

edited

Loading

auxves commented May 3, 2019 •

edited

Loading

nadiamoe commented May 26, 2019 •

edited

Loading

shanalikhan commented Jun 10, 2019 •

edited

Loading