Add default value for vector type input parameters #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MengnanLi91
force-pushed
the
input_vector_parameter_fix
branch
from
4a84476 to
79cd68a
Compare
|
Job Precheck on 79cd68a wanted to post the following: Your code requires style changes. A patch was auto generated and copied here
Alternatively, with your repository up to date and in the top level of your repository:
|
MengnanLi91
force-pushed
the
input_vector_parameter_fix
branch
from
0c46018 to
aceeb88
Compare
|
Job Documentation on aceeb88 wanted to post the following: View the site here This comment will be updated on new commits. |
gsgall
pushed a commit
to gsgall/zapdos
that referenced
this pull request
Oct 26, 2023
csdechant
pushed a commit
to csdechant/zapdos
that referenced
this pull request
Sep 4, 2024
csdechant
pushed a commit
to csdechant/zapdos
that referenced
this pull request
Oct 3, 2024
csdechant
pushed a commit
to csdechant/zapdos
that referenced
this pull request
Nov 7, 2024
csdechant
pushed a commit
to csdechant/zapdos
that referenced
this pull request
Nov 22, 2024
csdechant
pushed a commit
to csdechant/zapdos
that referenced
this pull request
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Description
Refer to the issue #24455, a fix is introduced to MOOSE to properly report error when no default value is provided for vector type input parameter. This new fix in MOOSE cause several tests failed in Zapdos which don't provide default value for vector parameter.
Impact
This patch is made to fix the failed Zapdos tests due to the new changes in MOOSE