Athena/pr 352 debugging #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* All tests share the Athena connection. * Added connect() test and ensured it runs first, so that connection.athenaClient is defined for the remaining tests. * Defined helper function mockAthenaResponses(query, columnNames, rows). * Fixed tables() test (tables() shouldn't return the column name `table_names`).
* Fixed tables() so that it doesn't return the column name table_names. * Avoided the creation of unnecessary promises. * Used slice() and map() to generate the response rows.
shannonlal
pushed a commit
that referenced
this pull request
Jul 28, 2018
* Add scheduler * Add sort fns * Move info to props and use defaultProps for mock * Create scheduled query button * Number bug fix * Fix search and sort * Use rowGetter * Use selectors * Remove stage 2 and 3 code * fetch scheduled queries and add to store * Add PropTypes * Fix column resize issue * save all queries in the store and filter by connection in Settings component * Use react-click-outside, preview modal * Create modal factory, lint * Extract Modal, Row, Column components to own files * add SQL syntax highlighting in schedule tab * misc style fixes, add modal close button * add tests for Scheduler, update Scheduler/Modal with fixes found testing * Review Comments #1: - Add comment - Remove old code - Add ms dev * .js extensions * Word wrap SQL preview * Add Layout description comment * Comment react-data-grid formatters * Rename .react.js -> .jsx, import css files * Fix indentation * Better preview header spacing * Bold SQL preview header * Move new deps to devDependencies * Make SchedulerPreview * test/app/components/Settings/Scheduler/Scheduler.test.js -> test/app/components/Settings/scheduler.test.jsx * adapt scheduler test to additional sql element in query modal * Fix scheduler-table styling issues * add className prop type to SQL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@shannonlal I got to fix the tests. I can't test the frontend. Please, let me know if these changes also fix the issue with the frontend.
A brief explanation of the changes:
connect(conn),conn.athenaClientwas undefined.createAthenaClientback todrivers/athena.jswhile debugging, but it could perfectly stay inathena.js; sorry about that). Although the only problem inathena.jswastables(), I also tried to simplify the code by removing the creation of unnecessaryPromise's and by usingsliceandmap.Please, let me know what you think of the changes.